Class plugin fails to parse Command Arguments

[drsooch]

Your environment

Steps to reproduce

In Development.IDE.Types.Logger adding:

instance Pretty ResponseError where

And attempting to generate the class method (with no signature) results in:

(error "error while parsing args for classplugin.codeaction in plugin class: expected Bool, but encountered Null
arg = Object (fromList [(\"methodGroup\",Array [Array [String \"pretty\",String \"pretty :: ResponseError -> Doc ann\"]]),(\"range\",Object (fromList [(\"end\",Object (fromList [(\"character\",Number 29.0),(\"line\",Number 371.0)])),(\"start\",Object (fromList [(\"character\",Number 9.0),(\"line\",Number 371.0)]))])),(\"uri\",String \"file://~/redacted/haskell-language-server/ghcide/src/Development/IDE/Types/Logger.hs\"),(\"withSig\",Null)])")

FYI: this is part of log-response-errors branch so it is not in master so this will not be seen.

Expected behaviour

The generated class method to be shown

Include debug information

GHC-9.0.2 - HLS built from master (with minor changes to log messages)

[Ailrun]

@July541, could you check this? It sounds like introduced in #2920.

[July541]

@drsooch I built your log-response-errors branch with ghc-9.0.2 but cant repro your error. Did I miss something?

[drsooch]

@drsooch I built your log-response-errors branch with ghc-9.0.2 but cant repro your error. Did I miss something?

Can you add the instance declaration to the bottom of the file? That's where I saw the issue.

[July541]

Can you add the instance declaration to the bottom of the file? That's where I saw the issue.

Looks fine.

instance Pretty ResponseError where  pretty = _

I just noticed this #2998, but your error message seems not possible, not sure how the type miss-match happened...

[drsooch]

Hmm, seems like it's a client issue... Can't reproduce in VSCode. Will close?

[July541]

Aha, change to raise a lsp client bug?

[Ailrun]

Close this as not reproduced in other editors