-
Notifications
You must be signed in to change notification settings - Fork 6
Dev/sync time validity #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Poofjunior
wants to merge
13
commits into
harp-tech:main
Choose a base branch
from
AllenNeuralDynamics:dev/sync_time_validity
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+46
−7
Open
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d99f5f9
update clock sync page
Poofjunior 4fca7cc
Update SynchronizationClock.md
Poofjunior 3fa8382
add sender/receiver schematic
Poofjunior 4ac5782
update graphic display cmd
Poofjunior 0b7d0d8
reorg text
Poofjunior dda0bb4
specify audio cable size
Poofjunior d31ae7d
add pico hardware template
Poofjunior 6f4a9b5
update clock sync pic and make note important
Poofjunior 32956cc
remove unrelated note
Poofjunior 65efd96
typo
Poofjunior 886ce32
pascal-case-ify image names
Poofjunior c72551a
move physical connector pdf to assets
Poofjunior 0a26eab
remove extraneous folder
Poofjunior File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add sender/receiver schematic
- Loading branch information
commit 3fa83828c8ddf68b37c0776f38a13384556f231f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably move the original connector PDF into the assets folder.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved (and also moved the .sch file).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed for this specific one you created a separate folder for both the .sch and the .pdf files. Since we didn't do this separation yet for the other ones, could you move them both back to the root of the assets folder for now?
We could end up deciding it makes sense to have independent folder schematics, but in that case I would rather we do a single consistent refactoring for all assets simultaneously in a separate PR.