[FFM-11241] - Target v2: Adding support for AND/OR in clauses #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What Adding support for processing the new `GroupServingRule` in `Segment`. Also update API definition for OpenAPIGenerator plugin. The default behaviour now is to check for the existence of `GroupServingRule` if found then we ignore the old `Rules` section. Old `Rules` section will continue to work to aid transition if `GroupServingRule` is not yet populated. Each entry in `GroupServingRule` is ORed while each list of clauses is ANDed. The `GroupServingRule` with the highest priority used first to allow reordering on the backend. Why This give the customer more flexibility on how they configure their rules in the backend. Testing Initial unit tests for now + testgrid later
erdirowlands
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FFM-11241 - Target v2: Adding support for AND/OR in clauses
What
Adding support for processing the new
GroupServingRuleinSegment. Also update API definition for OpenAPIGenerator plugin. The default behaviour now is to check for the existence ofGroupServingRuleif found then we ignore the oldRulessection. OldRulessection will continue to work to aid transition ifGroupServingRuleis not yet populated. Each entry inGroupServingRuleis ORed while each list of clauses is ANDed. TheGroupServingRulewith the highest priority used first to allow reordering on the backend.Why
This give the customer more flexibility on how they configure their rules in the backend.
Testing
Initial unit tests for now + testgrid later