Skip to content

Conversation

@hassanshamim
Copy link

No description provided.

@hassanshamim
Copy link
Author

Turns out django_db_geventpool supports postgis driver so just updated the nonstaging information appropriately.

@BrianHGrant
Copy link
Member

My main concern with using the gevent based packages was some conflicts with the django dev server that were run into last year. If it works in the dev environment let's use the same driver

@MikeTheCanuck
Copy link
Contributor

I'm not familiar with the details of the drivers - will this support both PostGIS and non-PostGIS targets? e.g. if in the future we deployed a PostgreSQL-only database service, and a separate PostGIS-enabled database service, would apps using this one driver be able to successfully interact with either target?

@hassanshamim
Copy link
Author

Mike, We can specify the driver to be used in the database configurations, so if Django were to connect to 2 different databases it could use 2 different drivers. postgis/postgres/sql/mysql doesn't matter.

Brian, I'm happy to change from gevent back to regular postgis. From what I can tell though we only use the gevent based driver in production not dev. Not an ops guy but I assume we don't do any db connection pooling with the dev settings. The gevent based driver should be increasing the performance of our production system.

I have no strong opinions one way or another, just wanted to backport the changes I made when setting up the neighborhood's api based on the exemplar.

@BrianHGrant
Copy link
Member

@hassanshamim I would say using the standard postgis in development and the gevent_pooling in prod would work.

@znmeb znmeb self-requested a review May 21, 2018 02:38
Copy link
Contributor

@znmeb znmeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this in the development version this afternoon on the Transportation database and it appears to be working. If there are other tests anyone wants run, let me know and I'll do them

@bhgrant8
Copy link
Member

bhgrant8 commented Aug 8, 2018

Note: due to issues with gevent_pooling we have gone with the default postgis driver:

'django.contrib.gis.db.backends.postgis'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants