Skip to content

fix: properly calculate the direct highestVulnerability #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2024
Merged

fix: properly calculate the direct highestVulnerability #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/com/redhat/exhort/integration/providers/ProviderResponseHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,8 @@ public Source buildReportForSource(
&& !depEntry.getKey().isCoordinatesEquals(recommendation.packageName())) {
directReport.recommendation(recommendation.packageName());
}
directReport.setHighestVulnerability(issues.stream().findFirst().orElse(null));
directReport.setHighestVulnerability(
directReport.getIssues().stream().findFirst().orElse(null));
List<TransitiveDependencyReport> transitiveReports =
depEntry.getValue().transitive().stream()
.map(
Expand Down
37 changes: 37 additions & 0 deletions src/test/java/com/redhat/exhort/integration/providers/ProviderResponseHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,43 @@ public void testSorted() throws IOException {
assertEquals("aa", reportLowest.getRef().name());
assertEquals("aaa", reportLowest.getTransitive().get(0).getRef().name());
assertEquals("aab", reportLowest.getTransitive().get(1).getRef().name());

assertEquals("ISSUE-006", reportHighest.getHighestVulnerability().getId());
assertEquals("ISSUE-001", reportLowest.getHighestVulnerability().getId());
}

@Test
public void testHighestVulnerabilityInDirectDependency() throws IOException {
Map<String, List<Issue>> issues =
Map.of("pkg:npm/aa@1", List.of(buildIssue(1, 4f), buildIssue(2, 9f), buildIssue(3, 1f)));
ProviderResponseHandler handler = new TestResponseHandler();

ProviderReport response =
handler.buildReport(
new ProviderResponse(issues, null), buildTree(), null, EMPTY_TRUSTED_CONTENT_RESPONSE);

assertOkStatus(response);
DependencyReport highest = getValidSource(response).getDependencies().get(0);
assertEquals("ISSUE-002", highest.getHighestVulnerability().getId());
assertEquals(9f, highest.getHighestVulnerability().getCvssScore());
}

@Test
public void testHighestVulnerabilityInTransitiveDependency() throws IOException {
Map<String, List<Issue>> issues =
Map.of(
"pkg:npm/aa@1", Collections.emptyList(),
"pkg:npm/aaa@1", List.of(buildIssue(1, 4f), buildIssue(2, 9f), buildIssue(3, 1f)));
ProviderResponseHandler handler = new TestResponseHandler();

ProviderReport response =
handler.buildReport(
new ProviderResponse(issues, null), buildTree(), null, EMPTY_TRUSTED_CONTENT_RESPONSE);

assertOkStatus(response);
DependencyReport highest = getValidSource(response).getDependencies().get(0);
assertEquals("ISSUE-002", highest.getHighestVulnerability().getId());
assertEquals(9f, highest.getHighestVulnerability().getCvssScore());
}

@Test
Expand Down