Skip to content

Conversation

@zvigrinberg
Copy link
Contributor

@zvigrinberg zvigrinberg commented Dec 5, 2023

Integrate Trusted content recommendations into EXHORT' response payload.

  1. Enrich response payload with Trusted Content recommendations fetched from TC Service' /recommend endpoint
  2. For each dependency' purl, if recommendation exists, add the corresponding recommendation purl.
  3. If recommendations are not found, then response body of exhort should remain the same without changes.

Remark: TC service' endpoint - /recommend is under ongoing development, so integration changes caused by it might follow.

Signed-off-by: Zvi Grinberg <[email protected]>
also modify response payload of trusted content /recommend and adjust tests accordingly

Signed-off-by: Zvi Grinberg <[email protected]>
@zvigrinberg zvigrinberg force-pushed the feature/add-tc-recommendations branch from 3168332 to 286a3d7 Compare December 6, 2023 06:17
@zvigrinberg zvigrinberg force-pushed the feature/add-tc-recommendations branch 2 times, most recently from a025aad to 5bc0772 Compare December 6, 2023 10:00
@zvigrinberg zvigrinberg requested a review from ruromero December 6, 2023 10:01
@zvigrinberg zvigrinberg force-pushed the feature/add-tc-recommendations branch from 5bc0772 to 7bc1f61 Compare December 6, 2023 10:03
Copy link
Collaborator

@ruromero ruromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @zvigrinberg I have added some suggestions although the functionality doesn't change, it aligns with the existing code

@ruromero
Copy link
Collaborator

ruromero commented Dec 7, 2023

I have one concern about the overall approach. Wouldn't it be simpler to call the trustedContent before the providers and then keep the response in the exchange so that in the response handling we can have a common code to aggregate individually not only for recommendations but also for remediations as there will be where we have the CVEs information.

@zvigrinberg
Copy link
Contributor Author

I have one concern about the overall approach. Wouldn't it be simpler to call the trustedContent before the providers and then keep the response in the exchange so that in the response handling we can have a common code to aggregate individually not only for recommendations but also for remediations as there will be where we have the CVEs information.

Let's discuss it tomorrow.

Signed-off-by: Zvi Grinberg <[email protected]>
@zvigrinberg zvigrinberg force-pushed the feature/add-tc-recommendations branch from bcfb944 to baa5abc Compare December 11, 2023 08:31
In order to enforce unified error handling process

Signed-off-by: Zvi Grinberg <[email protected]>
@zvigrinberg zvigrinberg requested a review from ruromero December 12, 2023 11:08
@zvigrinberg
Copy link
Contributor Author

@ruromero As discussed, all the changes that you've requested are here, Please review and approve.

Signed-off-by: Zvi Grinberg <[email protected]>
@zvigrinberg zvigrinberg requested a review from ruromero December 12, 2023 15:52
@zvigrinberg zvigrinberg merged commit ebd0c1d into guacsec:main Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants