Skip to content

TC-570, TC-588: fixed pagination and search box error message. #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2023
Merged

TC-570, TC-588: fixed pagination and search box error message. #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/resources/freemarker/templates/generated/main.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/main/resources/freemarker/templates/generated/vendor.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/main/resources/freemarker/templates/generated/vendor.js
View file
Open in desktop

Large diffs are not rendered by default.

20 changes: 10 additions & 10 deletions ui/src/components/DependenciesTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,23 @@ import {
Divider,
EmptyState,
EmptyStateBody,
EmptyStateHeader,
EmptyStateIcon,
EmptyStateVariant,
SearchInput,
Stack,
StackItem,
Title,
Toolbar,
ToolbarContent,
ToolbarItem,
ToolbarItemVariant,
ToolbarToggleGroup,
} from '@patternfly/react-core';
import {ExpandableRowContent, Table, Tbody, Td, Th, Thead, Tr} from '@patternfly/react-table';
import {ExpandableRowContent, Table, TableVariant, Tbody, Td, Th, Thead, Tr} from '@patternfly/react-table';
import spacing from '@patternfly/react-styles/css/utilities/Spacing/spacing';
import FilterIcon from '@patternfly/react-icons/dist/esm/icons/filter-icon';
import CubesIcon from '@patternfly/react-icons/dist/esm/icons/cubes-icon';
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';


import {useAppContext} from '../App';
import {Dependency} from '../api/report';
Expand Down Expand Up @@ -149,13 +150,12 @@ export const DependenciesTable = () => {
numRenderedColumns={8}
noDataEmptyState={
<EmptyState variant={EmptyStateVariant.sm}>
<EmptyStateIcon icon={CubesIcon} />
<Title headingLevel="h2" size="lg">
No vulnerabilities found
</Title>
<EmptyStateBody>
The vulnerability scan did not find any vulnerabilities in your project.
</EmptyStateBody>
<EmptyStateHeader
icon={<EmptyStateIcon icon={SearchIcon} />}
titleText="No results found"
headingLevel="h2"
/>
<EmptyStateBody>Clear all filters and try again.</EmptyStateBody>
</EmptyState>
}
>
Expand Down
1 change: 0 additions & 1 deletion ui/src/components/TableControls/SimplePagination.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ export const SimplePagination: React.FC<ISimplePaginationProps> = ({
onPerPageSelect={(_, perPage) => {
onChange({ page: 1, perPage });
}}
isCompact={isTop || isCompact}
widgetId="pagination-options-menu"
variant={isTop ? PaginationVariant.top : PaginationVariant.bottom}
perPageOptions={mapPerPageOptions(perPageOptions || [10, 20, 50, 100])}
Expand Down