Skip to content

[PSM interop] Don't fail target if sub-target already failed #33222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2023
Merged

[PSM interop] Don't fail target if sub-target already failed #33222

merged 1 commit into from
May 31, 2023

Conversation

XuanWang-Amos
Copy link
Contributor

@XuanWang-Amos XuanWang-Amos commented May 23, 2023 •
edited by sergiitk
Loading

We configured TestGrid to file bug separately for each failed sub-target, if we still fail the main target, TestGrid will fail duplicate bugs.

ref b/280934327

@XuanWang-Amos XuanWang-Amos added release notes: no Indicates if PR should not be in release notes area/psm interop labels May 23, 2023
@XuanWang-Amos XuanWang-Amos requested a review from sergiitk May 23, 2023 21:24
@XuanWang-Amos XuanWang-Amos marked this pull request as ready for review May 23, 2023 21:24
@sergiitk sergiitk changed the title [xds interop] don't fail target if sub-target already failed [PSM interop] Don't fail target if sub-target already failed May 30, 2023
sergiitk
sergiitk approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should go with this. I didn't figure out any better solution.
FYI @gnossen @ejona86

@XuanWang-Amos XuanWang-Amos merged commit 40ee908 into grpc:master May 31, 2023
@XuanWang-Amos XuanWang-Amos deleted the xds_duplicate_bugs branch May 31, 2023 19:58
XuanWang-Amos added a commit that referenced this pull request May 31, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (#33222)
3fc228c 
We configured TestGrid to file bug separately for each failed
sub-target, if we still fail the main target, TestGrid will fail
duplicate bugs.
XuanWang-Amos added a commit that referenced this pull request May 31, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (#33222)
5fb8484 
We configured TestGrid to file bug separately for each failed
sub-target, if we still fail the main target, TestGrid will fail
duplicate bugs.
XuanWang-Amos added a commit that referenced this pull request May 31, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (#33222)
fd263cc 
We configured TestGrid to file bug separately for each failed
sub-target, if we still fail the main target, TestGrid will fail
duplicate bugs.
XuanWang-Amos added a commit that referenced this pull request May 31, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (#33222)
873efbf 
We configured TestGrid to file bug separately for each failed
sub-target, if we still fail the main target, TestGrid will fail
duplicate bugs.
XuanWang-Amos added a commit that referenced this pull request May 31, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (#33222)
e45836e 
We configured TestGrid to file bug separately for each failed
sub-target, if we still fail the main target, TestGrid will fail
duplicate bugs.
XuanWang-Amos added a commit that referenced this pull request May 31, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (#33222)
68682d2 
We configured TestGrid to file bug separately for each failed
sub-target, if we still fail the main target, TestGrid will fail
duplicate bugs.
XuanWang-Amos added a commit that referenced this pull request May 31, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (#33222)
11e524d 
We configured TestGrid to file bug separately for each failed
sub-target, if we still fail the main target, TestGrid will fail
duplicate bugs.
XuanWang-Amos added a commit that referenced this pull request May 31, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (#33222)
c40b186 
We configured TestGrid to file bug separately for each failed
sub-target, if we still fail the main target, TestGrid will fail
duplicate bugs.
XuanWang-Amos added a commit that referenced this pull request May 31, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (#33222)
9bd80ff 
We configured TestGrid to file bug separately for each failed
sub-target, if we still fail the main target, TestGrid will fail
duplicate bugs.
XuanWang-Amos added a commit that referenced this pull request May 31, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (#33222)
5171273 
We configured TestGrid to file bug separately for each failed
sub-target, if we still fail the main target, TestGrid will fail
duplicate bugs.
sergiitk pushed a commit that referenced this pull request May 31, 2023
@XuanWang-Amos
[PSM interop] Don't fail target if sub-target already failed (#33222) (…
6894b4b 
…#33303)

We configured TestGrid to file bug separately for each failed
sub-target, if we still fail the main target, TestGrid will fail
duplicate bugs.




<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label May 31, 2023
@sergiitk sergiitk mentioned this pull request May 31, 2023
Merged
@XuanWang-Amos XuanWang-Amos mentioned this pull request Jun 1, 2023
Merged
XuanWang-Amos added a commit to XuanWang-Amos/grpc that referenced this pull request Jun 22, 2023
@XuanWang-Amos
[PSM interop] Don't fail url_map target if sub-target already failed (g…
a1fd3b1 
…rpc#33520)

Follow up change of grpc#33222.

We don't want file multiple bugs if any of the sub-tests of the
`url_map` test fails.
XuanWang-Amos added a commit to XuanWang-Amos/grpc that referenced this pull request Jun 22, 2023
@XuanWang-Amos
[PSM interop] Don't fail url_map target if sub-target already failed (g…
c0a666d 
…rpc#33520)

Follow up change of grpc#33222.

We don't want file multiple bugs if any of the sub-tests of the
`url_map` test fails.
XuanWang-Amos added a commit to XuanWang-Amos/grpc that referenced this pull request Jun 22, 2023
@XuanWang-Amos
[PSM interop] Don't fail url_map target if sub-target already failed (g…
0273232 
…rpc#33520)

Follow up change of grpc#33222.

We don't want file multiple bugs if any of the sub-tests of the
`url_map` test fails.
XuanWang-Amos added a commit to XuanWang-Amos/grpc that referenced this pull request Jun 22, 2023
@XuanWang-Amos
[PSM interop] Don't fail url_map target if sub-target already failed (g…
eaa426f 
…rpc#33520)

Follow up change of grpc#33222.

We don't want file multiple bugs if any of the sub-tests of the
`url_map` test fails.
XuanWang-Amos added a commit to XuanWang-Amos/grpc that referenced this pull request Jun 22, 2023
@XuanWang-Amos
[PSM interop] Don't fail url_map target if sub-target already failed (g…
b27ad08 
…rpc#33520)

Follow up change of grpc#33222.

We don't want file multiple bugs if any of the sub-tests of the
`url_map` test fails.
XuanWang-Amos added a commit to XuanWang-Amos/grpc that referenced this pull request Jun 22, 2023
@XuanWang-Amos
[PSM interop] Don't fail url_map target if sub-target already failed (g…
88efe4d 
…rpc#33520)

Follow up change of grpc#33222.

We don't want file multiple bugs if any of the sub-tests of the
`url_map` test fails.
XuanWang-Amos added a commit to XuanWang-Amos/grpc that referenced this pull request Jun 22, 2023
@XuanWang-Amos
[PSM interop] Don't fail url_map target if sub-target already failed (g…
72a2e95 
…rpc#33520)

Follow up change of grpc#33222.

We don't want file multiple bugs if any of the sub-tests of the
`url_map` test fails.
XuanWang-Amos added a commit to XuanWang-Amos/grpc that referenced this pull request Jun 22, 2023
@XuanWang-Amos
[PSM interop] Don't fail url_map target if sub-target already failed (g…
53eb266 
…rpc#33520)

Follow up change of grpc#33222.

We don't want file multiple bugs if any of the sub-tests of the
`url_map` test fails.
XuanWang-Amos added a commit to XuanWang-Amos/grpc that referenced this pull request Jun 22, 2023
@XuanWang-Amos
[PSM interop] Don't fail url_map target if sub-target already failed (g…
c38dba0 
…rpc#33520)

Follow up change of grpc#33222.

We don't want file multiple bugs if any of the sub-tests of the
`url_map` test fails.
This was referenced Jun 22, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
XuanWang-Amos added a commit that referenced this pull request Jun 22, 2023
@XuanWang-Amos
[PSM interop] Don't fail url_map target if sub-target already failed …
45480dd 
…(v1.56.x backport) (#33523)

Backport of #33520 to v1.56.x.
---
Follow up change of #33222.

We don't want file multiple bugs if any of the sub-tests of the
`url_map` test fails.

<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
XuanWang-Amos added a commit that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail url_map target if sub-target already failed …
36ea24e 
…(v1.55.x backport) (#33524)

Backport of #33520 to v1.55.x.
---
Follow up change of #33222.

We don't want file multiple bugs if any of the sub-tests of the
`url_map` test fails.

<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
veblush pushed a commit that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail url_map target if sub-target already failed …
e793a4b 
…(v1.48.x backport) (#33531)

Backport of #33520 to v1.48.x.
---
Follow up change of #33222.

We don't want file multiple bugs if any of the sub-tests of the
`url_map` test fails.

<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
veblush pushed a commit that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail url_map target if sub-target already failed …
da9ef34 
…(v1.54.x backport) (#33525)

Backport of #33520 to v1.54.x.
---
Follow up change of #33222.

We don't want file multiple bugs if any of the sub-tests of the
`url_map` test fails.

<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
veblush pushed a commit that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail url_map target if sub-target already failed …
aff3066 
…(v1.53.x backport) (#33526)

Backport of #33520 to v1.53.x.
---
Follow up change of #33222.

We don't want file multiple bugs if any of the sub-tests of the
`url_map` test fails.

<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
veblush pushed a commit that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail url_map target if sub-target already failed …
a221b3f 
…(v1.52.x backport) (#33527)

Backport of #33520 to v1.52.x.
---
Follow up change of #33222.

We don't want file multiple bugs if any of the sub-tests of the
`url_map` test fails.

<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
veblush pushed a commit that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail url_map target if sub-target already failed …
b0eba22 
…(v1.51.x backport) (#33528)

Backport of #33520 to v1.51.x.
---
Follow up change of #33222.

We don't want file multiple bugs if any of the sub-tests of the
`url_map` test fails.

<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
veblush pushed a commit that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail url_map target if sub-target already failed …
c1462cb 
…(v1.50.x backport) (#33529)

Backport of #33520 to v1.50.x.
---
Follow up change of #33222.

We don't want file multiple bugs if any of the sub-tests of the
`url_map` test fails.

<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
veblush pushed a commit that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail url_map target if sub-target already failed …
1c1c09e 
…(v1.49.x backport) (#33530)

Backport of #33520 to v1.49.x.
---
Follow up change of #33222.

We don't want file multiple bugs if any of the sub-tests of the
`url_map` test fails.

<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
veblush pushed a commit that referenced this pull request Jun 23, 2023
@XuanWang-Amos
[PSM interop] Don't fail url_map target if sub-target already failed …
e7835da 
…(v1.47.x backport) (#33532)

Backport of #33520 to v1.47.x.
---
Follow up change of #33222.

We don't want file multiple bugs if any of the sub-tests of the
`url_map` test fails.

<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
mario-vimal pushed a commit to mario-vimal/grpc that referenced this pull request Jul 13, 2023
@XuanWang-Amos @mario-vimal
[PSM interop] Don't fail url_map target if sub-target already failed (g…
3b23ded 
…rpc#33520)

Follow up change of grpc#33222.

We don't want file multiple bugs if any of the sub-tests of the
`url_map` test fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiitk sergiitk sergiitk approved these changes

@gnossen gnossen gnossen approved these changes

Assignees

@XuanWang-Amos XuanWang-Amos

Labels
area/psm interop bloat/none imported Specifies if the PR has been imported to the internal repository per-call-memory/neutral per-channel-memory/neutral release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuanWang-Amos @sergiitk @gnossen @yijiem