Skip to content

Conversation

gfrancz
Copy link
Contributor

@gfrancz gfrancz commented Jan 28, 2025

No description provided.

Copy link

linux-foundation-easycla bot commented Jan 28, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

@murgatroid99
Copy link
Member

Build error:

src/xds-client.ts:693:7 - error TS2322: Type 'void' is not assignable to type 'Timeout | null'.

693       this.statsTimer = clearInterval(this.statsTimer);
          ~~~~~~~~~~~~~~~

Please fix, and ensure that the code compiles before pushing, and please sign the CLA.

@gfrancz
Copy link
Contributor Author

gfrancz commented Feb 4, 2025

Ok sorry about that -- CLA is signed, I've confirmed it builds.

@ws-gregm
Copy link
Contributor

ws-gregm commented Feb 4, 2025

@murgatroid99 It appears that this PR and this one are blocked on Windows Tests which is failing because of timeout with test. I'm looking into it but I suspect it's a false fail.

@murgatroid99
Copy link
Member

Ignore the Windows tests. The test results are fine

Copy link
Member

@murgatroid99 murgatroid99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix.

@murgatroid99 murgatroid99 merged commit d2a6dda into grpc:master Feb 4, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants