Skip to content

Provide the method_name for the CallCredentials callback generateMetadata #2814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Provide the method_name for the CallCredentials callback generateMetadata #2814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/grpc-js/src/call-credentials.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import { Metadata } from './metadata';

export interface CallMetadataOptions {
method_name: string;
service_url: string;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/grpc-js/src/load-balancing-call.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ export class LoadBalancingCall implements Call, DeadlineInfoProvider {
switch (pickResult.pickResultType) {
case PickResultType.COMPLETE:
this.credentials
.generateMetadata({ service_url: this.serviceUrl })
.generateMetadata({ method_name: this.methodName, service_url: this.serviceUrl })
.then(
credsMetadata => {
/* If this call was cancelled (e.g. by the deadline) before
Expand Down
4 changes: 3 additions & 1 deletion packages/grpc-js/test/test-call-credentials.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ describe('CallCredentials', () => {
generateFromServiceURL
);
const metadata: Metadata = await callCredentials.generateMetadata({
method_name: 'bar',
service_url: 'foo',
});

Expand All @@ -98,7 +99,7 @@ describe('CallCredentials', () => {
CallCredentials.createFromMetadataGenerator(generateWithError);
let metadata: Metadata | null = null;
try {
metadata = await callCredentials.generateMetadata({ service_url: '' });
metadata = await callCredentials.generateMetadata({ method_name: '', service_url: '' });
} catch (err) {
assert.ok(err instanceof Error);
}
Expand Down Expand Up @@ -139,6 +140,7 @@ describe('CallCredentials', () => {
testCases.map(async testCase => {
const { credentials, expected } = testCase;
const metadata: Metadata = await credentials.generateMetadata({
method_name: '',
service_url: '',
});

Expand Down