grpc-js: Simplify pick_first behavior #2806
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a few related changes to the pick_first LB policy to simplify its behavior, in order to reduce the chances of reaching a bad state, and to make it easier to reason about:
pickSubchannel
, avoid assuming that the subchannel to be picked has any state related to this LB policy instance; in particular, don't assume that it has the state change listener registered, and don't have special case behavior if it's the same subchannel as the current pick. Instead, unconditionally reset the LB policy state and set up the relevant subchannel state from scratch.resetSubchannelList
, remove the special case when handling the current pick.connectToAddressList
, don't take any additional actions when immediately picking one of the new subchannels.removeCurrentPick
, callunref
last to completely avoid calling the connectivity state listener.updateAddressList
, switchrequestedResolutionSinceLastUpdate
tofalse
immediately instead of assuming that will be done elsewhere.