grpc-js: Avoid sending redundant RST_STREAMs from the client #2695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiitk
reviewed
Mar 26, 2024
There was a problem hiding this comment.
Was handling a similar-ish situation in java recently - preventing multiple RSTs when the on server failures. The difference in my case was needing to send a reset when our server transport failed for non-io reasons. grpc/grpc-java#11016
This LGTM, but let's chat for a few minutes before I approve this.
sergiitk
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the hypothesis that #2625 is caused by RST_STREAM rate limiting (for rapid reset mitigation), this change reduces the chances of that by avoiding sending an RST_STREAM from the client when the server has already half-closed its side of the connection.