grpc-js: Fix an error from a previous change, and enable a TS compiler options to prevent regressions #2503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2456, in
client.ts, development code that commented out the use of thecallerStackvariable in unary requests was mistakenly included in the final PR.In order to avoid this kind of error in the future, I also enabled the
noUnusedLocalsTypeScript compiler option, which would have make this mistake an error. In making the code changes that option required, I discovered and fixed another bug intransport.tsthat prevented the propagation of proxy information to channelz. The error is ignored in one place inserver-call.ts, where a field is accessed in an unusual way that the compiler does not recognize.