Skip to content

Conversation

larry-safran
Copy link
Contributor

Added for fixit

Fixes b/259286633

@larry-safran larry-safran requested a review from temawi March 16, 2023 18:04
Copy link
Contributor

@temawi temawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but take a look at the few comments I left.

try {
debugPort = Integer.parseInt(split[1]) + 1000;
} catch (NumberFormatException e) {
System.err.println("Invalid port number " + split[1]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The indent is off.

@larry-safran larry-safran merged commit 78fff08 into grpc:master Mar 17, 2023
@larry-safran larry-safran deleted the debug_example branch March 17, 2023 23:26
larry-safran added a commit to larry-safran/grpc-java that referenced this pull request Mar 20, 2023
Extensive README, a server that exposes channelz and has pauses, and a client that uses multiple channels also exposes channelz service and has a 30 second delay to allow people to run the grpcdebug tool.

Fixit b/259286633
larry-safran added a commit to larry-safran/grpc-java that referenced this pull request Mar 20, 2023
Extensive README, a server that exposes channelz and has pauses, and a client that uses multiple channels also exposes channelz service and has a 30 second delay to allow people to run the grpcdebug tool.

Fixit b/259286633
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants