netty: Count sent RST_STREAMs against limit #12277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Http2RstCounterEncoder has to be constructed before NettyServerHandler/Http2ConnectionHandler so it must be static. Thus the code/counters were moved into RstStreamCounter which then can be constructed earlier and shared. This depends on Netty 4.1.124 for a bug fix to actually call the encoder: netty/netty@be53dc3
ejona86
added
the
TODO:release blocker
kannanjgithub
approved these changes
Aug 18, 2025
ejona86
added
TODO:backport
kannanjgithub
pushed a commit
that referenced
this pull request
Aug 19, 2025
Http2RstCounterEncoder has to be constructed before NettyServerHandler/Http2ConnectionHandler so it must be static. Thus the code/counters were moved into RstStreamCounter which then can be constructed earlier and shared. This depends on Netty 4.1.124 for a bug fix to actually call the encoder: netty/netty@be53dc3 Backport of #12277
kannanjgithub
removed
the
TODO:backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Http2RstCounterEncoder has to be constructed before NettyServerHandler/Http2ConnectionHandler so it must be static. Thus the code/counters were moved into RstStreamCounter which then can be constructed earlier and shared.
This depends on Netty 4.1.124 for a bug fix to actually call the encoder:
netty/netty@be53dc3