xds: pick_first LB configuration #10181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configure pick_first load balancing if the xDS PickFirst LB config message is used in the Cluster load balancing config.
YifeiZhuang
reviewed
May 16, 2023
| * Builds a service config JSON object for the pick_first load balancer config based on the | ||
| * given config values. | ||
| */ | ||
| private static ImmutableMap<String, ?> buildPickFirstConfig(Boolean shuffleAddressList) { |
There was a problem hiding this comment.
why wrap it to Boolean again? it was bool from proto.
There was a problem hiding this comment.
Good catch. I was copying the approach used with other fields to have null semantics, but that does not apply with bool proto fields. Changed it now, take a look.
YifeiZhuang
approved these changes
May 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure
pick_firstload balancing if the xDSPickFirstLB config message is specified in the load balancing config forCluster