gradle: Remove version pinning from POMs #10175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pinning is unreliable in Maven and ignored by Gradle. I'm not at all convinced that we are pinning/not pinning in appropriate projects. The pinning also serves less of a purpose since we started encouraging the BOM and grpc-netty-shaded. Netty's HTTP/2 API has also become somewhat stable compared to its earlier history. If we notice an up-tick in version skew, we can reinstate it. The pinning is annoying in the build.gradle code and causes Maven/Gradle to download the version list once a day, which can be troublesome to users unaware of how to tell the tools to work offline. It also opens our users to platform issues like seen in grpc#10043 and grpc#10086 where Maven Central's version list was incorrectly generated. Or like grpc#9664 where Gradle Plugin's repository caches packages from JCenter but the version list is not as cachable so exposed us to JCenter instability. This fixes grpc#8357, by way of "we think we won't worry any more." See 90db93b when it was originally introduced. And issues like grpc#8337, grpc#3634.
temawi
approved these changes
May 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pinning is unreliable in Maven and ignored by Gradle. I'm not at all convinced that we are pinning/not pinning in appropriate projects. The pinning also serves less of a purpose since we started encouraging the BOM and grpc-netty-shaded. Netty's HTTP/2 API has also become somewhat stable compared to its earlier history. If we notice an up-tick in version skew, we can reinstate it.
The pinning is annoying in the build.gradle code and causes Maven/Gradle to download the version list once a day, which can be troublesome to users unaware of how to tell the tools to work offline.
It also opens our users to platform issues like seen in #10043 and #10086 where Maven Central's version list was incorrectly generated. Or like #9664 where Gradle Plugin's repository caches packages from JCenter but the version list is not as cachable so exposed us to JCenter instability.
This fixes #8357, by way of "we think we won't worry any more." See 90db93b when it was originally introduced. And issues like #8337, #3634.