xds: handle the handlerRemoved callback to skip updateSslContext processing #10118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essing
In handlerAdded we submit a callback to updateSslContext but before the
callback is executed the handler could be removed (e.g. bad connection)
in which case the callback should skip all of the processing.
Also added a unit test to check there is no exception.
ejona86
reviewed
May 1, 2023
xds/src/main/java/io/grpc/xds/internal/security/SecurityProtocolNegotiators.java
Outdated
Show resolved
Hide resolved
xds/src/main/java/io/grpc/xds/internal/security/SecurityProtocolNegotiators.java
Outdated
Show resolved
Hide resolved
ejona86
approved these changes
May 2, 2023
|
fixes #10119 |
ejona86
pushed a commit
to ejona86/grpc-java
that referenced
this pull request
May 3, 2023
…essing (grpc#10118) * xds: handle the handlerRemoved callback to skip updateSslContext processing In handlerAdded we submit a callback to updateSslContext but before the callback is executed the handler could be removed (e.g. bad connection) in which case the callback should skip all of the processing. Also added a unit test to check there is no exception.
ejona86
pushed a commit
that referenced
this pull request
May 3, 2023
…essing (#10118) * xds: handle the handlerRemoved callback to skip updateSslContext processing In handlerAdded we submit a callback to updateSslContext but before the callback is executed the handler could be removed (e.g. bad connection) in which case the callback should skip all of the processing. Also added a unit test to check there is no exception.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the issue in https://groups.google.com/g/grpc-io/c/KR5FCi5wD0s/m/eEtHNszmAgAJ