Migrate from JSR305's javax.annotation.CheckReturnValue to ErrorProne's com.google.errorprone.annotations.CheckReturnValue

[dapengzhang0]

Initiated by cl/408694635

[kluever]

See also cl/408694507

[RamAnvesh]

Hi Any update on this?

Summary of the issue:
When using grpc-java in a modularized application, I was facing issues with javax.annotation.Generated annotation. The fix for this suggested was to add javax.annotation-api as a dependency.
But after doing this, the javax.annotation.CheckReturnValue is not being read from the jsr-305 jar.

[vietj]

there are actually a bunch of annotations that are used in the codebase that rely on the javax.annotation package:

• Nullable
• Immutable
• ThreadSafe
• etc...

such annotations prevent using io.grpc as JPMS module, e.g.

[ERROR] module io.grpc.util reads package javax.annotation from both java.annotation and jsr305
[ERROR] module io.grpc.stub reads package javax.annotation from both java.annotation and jsr305

I am willing contributing the migration to error prone (which does not seem trivial), is that a contribution that would be accepted by the grpc-java project ?

[vietj]

ping @ejona86