Skip to content

Conversation

HannahShiSFB
Copy link
Collaborator

@HannahShiSFB HannahShiSFB commented Apr 24, 2023

This excludes src/objective-c/manual_tests/ from swift package build, fixes firebase/firebase-ios-sdk#10650 building for macos and tvos. Also added them to CI.

@sampajano

* add new include for v1.54.0

* remove use_frameworks! to work with new boring ssl
@HannahShiSFB HannahShiSFB marked this pull request as ready for review April 24, 2023 16:04
@HannahShiSFB HannahShiSFB enabled auto-merge (squash) April 24, 2023 16:06
@HannahShiSFB HannahShiSFB force-pushed the exclude-ios-tests-from-swift-package branch from 38a1a36 to 5073335 Compare April 24, 2023 16:56
@HannahShiSFB HannahShiSFB force-pushed the exclude-ios-tests-from-swift-package branch from 5073335 to 3e9a761 Compare April 24, 2023 18:24
Copy link
Collaborator

@sampajano sampajano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HannahShiSFB Thanks!! 😃

@HannahShiSFB HannahShiSFB merged commit f246e93 into grpc:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants