-
Notifications
You must be signed in to change notification settings - Fork 4.6k
credentials: implement file-based JWT Call Credentials (part 1 for A97) #8431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 60 commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
6e63daa
xds: read JWT credentials from file as per A97
dimpavloff 3268ea5
remove example
dimpavloff b18a1f5
refactor test creation
dimpavloff eb391af
refactor token string padding
dimpavloff d43893a
remove example; mark as experimental
dimpavloff 167b86e
reorganise struct attributes
dimpavloff 439d28c
rename methods with Locked suffix
dimpavloff b36d4b6
remove context param from refreshTokenSync
dimpavloff 26e0451
reformat comments; remove redundant cachedErrorTime field
dimpavloff da2de8c
add defaultTestTimeout const
dimpavloff 51ce34c
refactor test to use wantErr string only
dimpavloff f87f1f2
fix punctuation
dimpavloff 15dd057
less prosaic subtest names
dimpavloff 54cbbcb
remove unit test
dimpavloff 9c5035d
rename preemptiveRefresh to forceRefresh
dimpavloff ec915dc
remove unused context param
dimpavloff 1d95fa2
rename files
dimpavloff a797ed9
use cond variable
dimpavloff fd388d1
refactor to no longer need cond
dimpavloff 790a2d9
fix docstring comment
dimpavloff 6713190
cache authorization header instead of token
dimpavloff 3f563eb
remove internal/ and xds/ changes
dimpavloff a38573b
remove xds/bootstrap
dimpavloff 12fedd5
fix comment docstrings
dimpavloff 52445c7
remove newJWTFileReader
dimpavloff 1678016
make ReadToken private method
dimpavloff 1be843b
use subtests
dimpavloff 8ac3296
use writeTempFile
dimpavloff b0bdc70
add comment about RPC queue behaviour
dimpavloff e4f955c
remove needsPreemptiveRefreshLocked method
dimpavloff f78178c
split NewTokenFileCallCredentials tests
dimpavloff bbeb759
remove leftover os.MkdirTemp
dimpavloff bba5d34
remove audience parameter and do not set it at all for test tokens
dimpavloff 607868b
test for grpc codes in TestTokenFileCallCreds_GetRequestMetadata
dimpavloff bc2d327
use cmp.Diff in TestTokenFileCallCreds_TokenCaching
dimpavloff 330d9a8
fix createTestJWT docstring
dimpavloff 774d83e
refactor readToken() and tests to use error values
dimpavloff b9dcfcb
remove errJWTFormat in favour of validation error
dimpavloff 6ee5ba7
error wrapping
dimpavloff 14c5ccd
subtests with underscores only
dimpavloff ca8227d
change credentials.CheckSecurityLevel error mgs; success path identation
dimpavloff ff50123
re-order assertions
dimpavloff c05da9f
remove string comparisons
dimpavloff 3f9195e
add TODO to tests
dimpavloff 2c9a06d
rename jWTFileReader to jwtFileReader
dimpavloff 42c6804
move error wrapping
dimpavloff f1a1cd3
remove leftover package docstring
dimpavloff 2b8ae01
use RawURLEncoding.DecodeString
dimpavloff 1b5a609
%v instead of %w in credentials.CheckSecurityLevel error string
dimpavloff 4c30c68
single check for preemptive refresh
dimpavloff 0c15d73
clarify why lock is not used and document concurrent calls for jwtFil…
dimpavloff 7d5f578
rename test suite function name
dimpavloff c8852fc
trailing brace in comment
dimpavloff 0be0243
add comments to clarify we do not trigger refresh on updating the cac…
dimpavloff 36042db
shouldTriggerRefresh failure message update
dimpavloff 7e50e3e
re-use err instead of err1,2,3,4,5
dimpavloff 8e3b91b
improve err==nil failure message in test
dimpavloff 4ac6f4c
t.Fatal and t.Error message capitalisation where possible
dimpavloff e83fbee
combine t.Error into a single t.Fatal and indent
dimpavloff 75fbc02
attempt to make the token referesh retry backoff test more readable
dimpavloff eae450a
rename function, omit zero value param, formatting
dimpavloff 3b651c2
strip jwt_ prefix from filenames
dimpavloff 4336d04
use strings.Cut to extract claims
dimpavloff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
/* | ||
* | ||
* Copyright 2025 gRPC authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* | ||
*/ | ||
|
||
// Package jwt implements JWT token file-based call credentials. | ||
// | ||
// This package provides support for A97 JWT Call Credentials, allowing gRPC | ||
// clients to authenticate using JWT tokens read from files. While originally | ||
// designed for xDS environments, these credentials are general-purpose. | ||
// | ||
// The credentials can be used directly in gRPC clients or configured via xDS. | ||
// | ||
// # Token Requirements | ||
// | ||
// JWT tokens must: | ||
// - Be valid, well-formed JWT tokens with header, payload, and signature | ||
// - Include an "exp" (expiration) claim | ||
// - Be readable from the specified file path | ||
// | ||
// # Considerations | ||
// | ||
// - Tokens are cached until expiration to avoid excessive file I/O | ||
// - Transport security is required (RequireTransportSecurity returns true) | ||
// - Errors in reading tokens or parsing JWTs will result in RPC UNAVAILALBE or | ||
// UNAUTHENTICATED errors. The errors are cached and retried with exponential | ||
// backoff. | ||
// | ||
// This implementation is originally intended for use in service mesh | ||
// environments like Istio where JWT tokens are provisioned and rotated by the | ||
// infrastructure. | ||
// | ||
// # Experimental | ||
// | ||
// Notice: All APIs in this package are experimental and may be removed in a | ||
// later release. | ||
package jwt | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,98 @@ | ||
/* | ||
* | ||
* Copyright 2025 gRPC authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* | ||
*/ | ||
|
||
package jwt | ||
|
||
import ( | ||
"encoding/base64" | ||
"encoding/json" | ||
"errors" | ||
"fmt" | ||
"os" | ||
"strings" | ||
"time" | ||
) | ||
|
||
var ( | ||
errTokenFileAccess = errors.New("token file access error") | ||
errJWTValidation = errors.New("invalid JWT") | ||
) | ||
|
||
// jwtClaims represents the JWT claims structure for extracting expiration time. | ||
type jwtClaims struct { | ||
Exp int64 `json:"exp"` | ||
} | ||
|
||
// jwtFileReader handles reading and parsing JWT tokens from files. | ||
// It is safe to call methods on this type concurrently as no state is stored. | ||
type jwtFileReader struct { | ||
tokenFilePath string | ||
} | ||
|
||
// readToken reads and parses a JWT token from the configured file. | ||
arjan-bal marked this conversation as resolved.
Show resolved
Hide resolved
|
||
// Returns the token string, expiration time, and any error encountered. | ||
func (r *jwtFileReader) readToken() (string, time.Time, error) { | ||
tokenBytes, err := os.ReadFile(r.tokenFilePath) | ||
if err != nil { | ||
return "", time.Time{}, fmt.Errorf("%v: %w", err, errTokenFileAccess) | ||
} | ||
|
||
token := strings.TrimSpace(string(tokenBytes)) | ||
if token == "" { | ||
return "", time.Time{}, fmt.Errorf("token file %q is empty: %w", r.tokenFilePath, errJWTValidation) | ||
} | ||
|
||
exp, err := r.extractExpiration(token) | ||
if err != nil { | ||
return "", time.Time{}, fmt.Errorf("token file %q: %v: %w", r.tokenFilePath, err, errJWTValidation) | ||
} | ||
|
||
return token, exp, nil | ||
} | ||
|
||
// extractExpiration parses the JWT token to extract the expiration time. | ||
func (r *jwtFileReader) extractExpiration(token string) (time.Time, error) { | ||
parts := strings.Split(token, ".") | ||
if len(parts) != 3 { | ||
return time.Time{}, fmt.Errorf("expected 3 parts, got %d", len(parts)) | ||
} | ||
|
||
payload := parts[1] | ||
payloadBytes, err := base64.RawURLEncoding.DecodeString(payload) | ||
if err != nil { | ||
return time.Time{}, fmt.Errorf("decode error: %v", err) | ||
} | ||
|
||
var claims jwtClaims | ||
if err := json.Unmarshal(payloadBytes, &claims); err != nil { | ||
return time.Time{}, fmt.Errorf("unmarshal error: %v", err) | ||
} | ||
|
||
if claims.Exp == 0 { | ||
return time.Time{}, fmt.Errorf("no expiration claims") | ||
} | ||
|
||
expTime := time.Unix(claims.Exp, 0) | ||
|
||
// Check if token is already expired. | ||
if expTime.Before(time.Now()) { | ||
return time.Time{}, fmt.Errorf("expired token") | ||
} | ||
|
||
return expTime, nil | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,172 @@ | ||
/* | ||
* | ||
* Copyright 2025 gRPC authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* | ||
*/ | ||
|
||
package jwt | ||
|
||
import ( | ||
"encoding/base64" | ||
"encoding/json" | ||
"errors" | ||
"fmt" | ||
"strings" | ||
"testing" | ||
"time" | ||
) | ||
|
||
func (s) TestJWTFileReader_ReadToken_FileErrors(t *testing.T) { | ||
tests := []struct { | ||
name string | ||
create bool | ||
contents string | ||
wantErr error | ||
}{ | ||
{ | ||
name: "nonexistent_file", | ||
create: false, | ||
contents: "", | ||
wantErr: errTokenFileAccess, | ||
}, | ||
{ | ||
name: "empty_file", | ||
create: true, | ||
contents: "", | ||
wantErr: errJWTValidation, | ||
}, | ||
{ | ||
name: "file_with_whitespace_only", | ||
create: true, | ||
contents: " \n\t ", | ||
wantErr: errJWTValidation, | ||
}, | ||
} | ||
|
||
for _, tt := range tests { | ||
t.Run(tt.name, func(t *testing.T) { | ||
var tokenFile string | ||
if !tt.create { | ||
tokenFile = "/does-not-exist" | ||
} else { | ||
tokenFile = writeTempFile(t, "token", tt.contents) | ||
} | ||
|
||
reader := jwtFileReader{tokenFilePath: tokenFile} | ||
if _, _, err := reader.readToken(); err == nil { | ||
t.Fatal("ReadToken() expected error, got nil") | ||
} else if !errors.Is(err, tt.wantErr) { | ||
t.Fatalf("ReadToken() error = %v, want error %v", err, tt.wantErr) | ||
} | ||
}) | ||
} | ||
} | ||
|
||
func (s) TestJWTFileReader_ReadToken_InvalidJWT(t *testing.T) { | ||
now := time.Now().Truncate(time.Second) | ||
tests := []struct { | ||
name string | ||
tokenContent string | ||
wantErr error | ||
}{ | ||
{ | ||
name: "valid_token_without_expiration", | ||
tokenContent: createTestJWT(t, time.Time{}), | ||
wantErr: errJWTValidation, | ||
}, | ||
{ | ||
name: "expired_token", | ||
tokenContent: createTestJWT(t, now.Add(-time.Hour)), | ||
wantErr: errJWTValidation, | ||
}, | ||
{ | ||
name: "malformed_JWT_not_enough_parts", | ||
tokenContent: "invalid.jwt", | ||
wantErr: errJWTValidation, | ||
}, | ||
{ | ||
name: "malformed_JWT_invalid_base64", | ||
tokenContent: "header.invalid_base64!@#.signature", | ||
wantErr: errJWTValidation, | ||
}, | ||
{ | ||
name: "malformed_JWT_invalid_JSON", | ||
tokenContent: createInvalidJSONJWT(t), | ||
wantErr: errJWTValidation, | ||
}, | ||
} | ||
|
||
for _, tt := range tests { | ||
t.Run(tt.name, func(t *testing.T) { | ||
tokenFile := writeTempFile(t, "token", tt.tokenContent) | ||
|
||
reader := jwtFileReader{tokenFilePath: tokenFile} | ||
if _, _, err := reader.readToken(); err == nil { | ||
t.Fatal("ReadToken() expected error, got nil") | ||
} else if !errors.Is(err, tt.wantErr) { | ||
easwars marked this conversation as resolved.
Show resolved
Hide resolved
|
||
t.Fatalf("ReadToken() error = %v, want error %v", err, tt.wantErr) | ||
} | ||
}) | ||
} | ||
} | ||
|
||
func (s) TestJWTFileReader_ReadToken_ValidToken(t *testing.T) { | ||
now := time.Now().Truncate(time.Second) | ||
tokenExp := now.Add(time.Hour) | ||
token := createTestJWT(t, tokenExp) | ||
tokenFile := writeTempFile(t, "token", token) | ||
|
||
reader := jwtFileReader{tokenFilePath: tokenFile} | ||
readToken, expiry, err := reader.readToken() | ||
if err != nil { | ||
t.Fatalf("ReadToken() unexpected error: %v", err) | ||
} | ||
|
||
if readToken != token { | ||
t.Errorf("ReadToken() token = %q, want %q", readToken, token) | ||
} | ||
|
||
if !expiry.Equal(tokenExp) { | ||
t.Errorf("ReadToken() expiry = %v, want %v", expiry, tokenExp) | ||
} | ||
} | ||
|
||
// createInvalidJSONJWT creates a JWT with invalid JSON in the payload. | ||
func createInvalidJSONJWT(t *testing.T) string { | ||
arjan-bal marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
t.Helper() | ||
|
||
header := map[string]any{ | ||
"typ": "JWT", | ||
"alg": "HS256", | ||
} | ||
|
||
headerBytes, err := json.Marshal(header) | ||
if err != nil { | ||
t.Fatalf("Failed to marshal header: %v", err) | ||
} | ||
|
||
headerB64 := base64.URLEncoding.EncodeToString(headerBytes) | ||
headerB64 = strings.TrimRight(headerB64, "=") | ||
|
||
// Create invalid JSON payload | ||
invalidJSON := "invalid json content" | ||
payloadB64 := base64.URLEncoding.EncodeToString([]byte(invalidJSON)) | ||
payloadB64 = strings.TrimRight(payloadB64, "=") | ||
|
||
signature := base64.URLEncoding.EncodeToString([]byte("fake_signature")) | ||
signature = strings.TrimRight(signature, "=") | ||
|
||
return fmt.Sprintf("%s.%s.%s", headerB64, payloadB64, signature) | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.