Client should update keepalive parameters upon receiving GoAway with … #1169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EnhanceYourCalm and debug data of too_many_pings.
menghanl
reviewed
Apr 5, 2017
clientconn.go
Outdated
| mu sync.RWMutex | ||
| sc ServiceConfig | ||
| conns map[Address]*addrConn | ||
|
|
There was a problem hiding this comment.
remove the empty line here to indicate that mkp is protected by mu?
| func (t *http2Client) GetGoAwayReason() GoAwayReason { | ||
| t.mu.Lock() | ||
| defer t.mu.Unlock() | ||
| return t.goAwayReason |
There was a problem hiding this comment.
Make this atomic read?
The lock is probably even not necessary...
There was a problem hiding this comment.
Following offline discussion leaving as is.
clientconn_test.go
Outdated
| } | ||
|
|
||
| type testserver struct { | ||
| tr transport.ServerTransport |
There was a problem hiding this comment.
Can we just start a gRPC server here?
dfawley
pushed a commit
to dfawley/grpc-go
that referenced
this pull request
Apr 17, 2017
grpc#1169) * Client should update keepalive parameters upon receiving GoAway with EnhanceYourCalm and debug data of too_many_pings.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…EnhanceYourCalm and debug data of too_many_pings.