Change nullable GetValueOrDefault to Value #1855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
BrennanConroy,
brunolins16,
captainsafia and
halter73
gfoidl
reviewed
Aug 21, 2022
There was a problem hiding this comment.
GetValueOrDefaultwas used to avoid null check inNullable<T>.Value. JIT in .NET 5/6/7 optimizes this away.
To state more precisely: only when the JIT can prove that there was a HasValue or != null check before.
src/Grpc.AspNetCore.Server/Internal/HttpContextSerializationContext.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Günther Foidl <[email protected]>
Co-authored-by: Günther Foidl <[email protected]>
BrennanConroy
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetValueOrDefaultwas used to avoid null check inNullable<T>.Value. JIT in .NET 5/6/7 optimizes this away.There probably is a very small perf hit on older platforms (.NET Framework/.NET Core 3), but IMO the easier-to-read and safer code is better.