update description of CAP_NET_RAW capability requirement #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This capability was required for Gremlin versions older than 2.18.2, because we would inherit the default capabilities of the container runtime, which sometimes included `CAP_NET_RAW`. Incidentally, we've depended on `CAP_NET_RAW` since [2.40.1][1] for another purpose: dependency discovery (when `gremlin.collect.dns=true`). Update the description for when and why this capability is needed. [1]: https://www.gremlin.com/docs/release-notes-linux#2-40-1
gremsam
approved these changes
Jul 25, 2024
fred-gremlin
approved these changes
Jul 26, 2024
ZachNo
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This capability was required for Gremlin versions older than 2.18.2, because our
runcdrivers would run sidecars with a "capabilities-add" request that was unaccompanied by a "drop-all" request andCAP_NET_RAWwas among those requested by default.Incidentally, we've depended on
CAP_NET_RAWsince 2.40.1 for another purpose: dependency discovery (whengremlin.collect.dns=true). Update the description for when and why this capability is needed.