Catch unhandled exception in abstract resolution #4392
Merged
+123
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
force-pushed
the
handle-unhandled-exception
branch
3 times, most recently
from
e3b2a5d to
7158830
Compare
benjie
reviewed
May 13, 2025
Co-authored-by: Benjie <[email protected]>
JoviDeCroock
force-pushed
the
handle-unhandled-exception
branch
7 times, most recently
from
d45f7d8 to
20263e7
Compare
Co-authored-by: Benjie <[email protected]>
saihaj
approved these changes
May 21, 2025
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
May 27, 2025
Co-authored-by: Benjie <[email protected]>
yaacovCR
pushed a commit
that referenced
this pull request
May 30, 2025
Co-authored-by: Benjie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4375
The assertion was correct that we have an unhandled Promise rejection going on when we have resolved a type and the rejection comes in at a later time.
We really have to revamp our tooling, the things that the linter is surfacing in tests and especially uncovered branches in tests... it really makes for a bad DX on this repo