polish(incremental): refactor getNewPending functionality #4108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yaacovCR
added
the
PR: polish 💅
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
force-pushed
the
refactor-getNewPending
branch
7 times, most recently
from
605bd1f to
0c05f32
Compare
return newPending alongside incremental results
yaacovCR
force-pushed
the
refactor-getNewPending
branch
from
0c05f32 to
c75866f
Compare
robrichard
reviewed
Jun 25, 2024
robrichard
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
return newPending alongside incremental results when completing a fragment
= removes need to track
newPendingandnewIncrementalDataRecordsas part of the class= unifies handling of retrieving new pending for initial result, completed fragments, and stream items incremental entries