Skip to content

Add support for @oneOf directives in printSchema #3969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2023
Merged

Add support for @oneOf directives in printSchema #3969

merged 1 commit into from
Nov 10, 2023

Conversation

hayes
Copy link
Contributor

@hayes hayes commented Sep 10, 2023

fixes #3968

@netlify
Copy link

netlify bot commented Sep 10, 2023 •
edited
Loading

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 4c544cd
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/64ff5a608c128a0008727170
😎 Deploy Preview https://deploy-preview-3969--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

IvanGoncharov
IvanGoncharov reviewed Sep 10, 2023
View reviewed changes
IvanGoncharov
IvanGoncharov reviewed Sep 10, 2023
View reviewed changes
@github-actions
Copy link

Hi @hayes, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@hayes
Copy link
Contributor Author

hayes commented Sep 22, 2023

anything else you need from my end to get this merged?

benjie
benjie approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this omission @hayes; this is critical!

@benjie

This comment has been minimized.

Sign in to view
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

@github-actions publish-pr-on-npm

@benjie The latest changes of this PR are available on NPM as
graphql@17.0.0-alpha.3.canary.pr.3969.83688beb16ecba5a0495158c3c2b3684730579bf
Note: no gurantees provided so please use your own discretion.

Also you can depend on latest version built from this PR:
npm install --save graphql@canary-pr-3969

@benjie
Copy link
Member

benjie commented Nov 9, 2023

@graphql/graphql-js-reviewers This seems like an easy merge now all the feedback has been addressed? 🙌

@saihaj saihaj requested a review from IvanGoncharov November 10, 2023 01:19
@saihaj saihaj merged commit 0b7590f into graphql:main Nov 10, 2023
@benjie benjie added the PR: bug fix 🐞 requires increase of "patch" version number label Jun 21, 2024
benjie pushed a commit that referenced this pull request Jun 21, 2024
@hayes @benjie
Add support for @OneOf directives in printSchema (#3969)
06e93b1 
fixes #3968
@benjie benjie mentioned this pull request Jun 21, 2024
Merged
@yaacovCR yaacovCR mentioned this pull request Sep 30, 2024
Closed
@jasonkuhrt jasonkuhrt mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjie benjie benjie approved these changes

@yaacovCR yaacovCR yaacovCR approved these changes

@saihaj saihaj saihaj approved these changes

@IvanGoncharov IvanGoncharov Awaiting requested review from IvanGoncharov

Assignees
No one assigned
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Printing the @oneOf directive
5 participants
@hayes @benjie @yaacovCR @IvanGoncharov @saihaj