Skip to content

OverlappingFieldsCanBeMergedRule: Fix performance degradation #3967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2023
Merged

OverlappingFieldsCanBeMergedRule: Fix performance degradation #3967

merged 2 commits into from
Sep 10, 2023

Conversation

AaronMoat
Copy link
Contributor

Applies fixes from #3958 into 16.x.x, fewer changes as no stream support in 16.

@AaronMoat AaronMoat mentioned this pull request Sep 5, 2023
Merged
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Hi @AaronMoat, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@AaronMoat AaronMoat mentioned this pull request Sep 5, 2023
Closed
@AaronMoat
Copy link
Contributor Author

@IvanGoncharov how closely do I need to pay attention to the codecov failure on this backport branch?

@IvanGoncharov
Copy link
Member

@IvanGoncharov how closely do I need to pay attention to the codecov failure on this backport branch?

@AaronMoat Sadly it breaks CI, but you can add a C8 comment to ignore those lines.

@IvanGoncharov IvanGoncharov added the PR: bug fix 🐞 requires increase of "patch" version number label Sep 6, 2023
@AaronMoat
Copy link
Contributor Author

Thanks @IvanGoncharov - added!

@IvanGoncharov IvanGoncharov merged commit 8f4c64e into graphql:16.x.x Sep 10, 2023
@AaronMoat
Copy link
Contributor Author

AaronMoat commented Sep 11, 2023 •
edited
Loading

Thanks @IvanGoncharov, appreciate all your help on this one! Is there a process to request a release for 16? As best I can tell this is manual not automated

@AaronMoat AaronMoat deleted the perf-fix branch September 11, 2023 09:10
@AaronMoat AaronMoat mentioned this pull request Sep 19, 2023
Closed
@brandingfuture brandingfuture mentioned this pull request May 19, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request May 25, 2024
Open
@mashraby mashraby mentioned this pull request May 25, 2024
Open
@Artur-data-DEV Artur-data-DEV mentioned this pull request Jun 4, 2024
Open
@schwer schwer mentioned this pull request Jun 13, 2024
Closed
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 19, 2024
Open
This was referenced Jul 3, 2024
Open
Open
Open
@Mhmonicox Mhmonicox mentioned this pull request Jul 4, 2024
Open
This was referenced Jul 4, 2024
Open
Open
@lwih lwih mentioned this pull request Jul 4, 2024
Merged
@fatihg61 fatihg61 mentioned this pull request Jul 4, 2024
Open
This was referenced Jul 4, 2024
Open
Open
@aduis aduis mentioned this pull request Jul 4, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request Jul 13, 2024
Open
@kalbroni7 kalbroni7 mentioned this pull request Jul 17, 2024
Open
@bryopsida bryopsida mentioned this pull request Jul 17, 2024
Closed
@carlocorradini carlocorradini mentioned this pull request Jul 17, 2024
Closed
@stephengtuggy stephengtuggy mentioned this pull request Jul 20, 2024
Merged
@Walkx01 Walkx01 mentioned this pull request Jul 25, 2024
Open
@xxdaggerxx xxdaggerxx mentioned this pull request Aug 4, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 9, 2024
Open
@parseplatformorg parseplatformorg mentioned this pull request Aug 15, 2024
Merged
@henriquebonfim henriquebonfim mentioned this pull request Aug 20, 2024
Open
@xorinzor xorinzor mentioned this pull request Aug 27, 2024
Merged
@GregBrimble GregBrimble mentioned this pull request Sep 7, 2024
Open
@fatihg61 fatihg61 mentioned this pull request Sep 9, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Sep 10, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Sep 11, 2024
Open
This was referenced Sep 11, 2024
Open
Open
Open
@ashu1409 ashu1409 mentioned this pull request Sep 18, 2024
Open
@mashraby mashraby mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 19, 2024
Open
Open
Open
Open
@X-oss-byte X-oss-byte mentioned this pull request Sep 23, 2024
Open
@Rose2161 Rose2161 mentioned this pull request Sep 23, 2024
Open
@jiridostal jiridostal mentioned this pull request Sep 28, 2024
Closed
@nerdy-tech-com-gitub nerdy-tech-com-gitub mentioned this pull request Oct 29, 2024
Open
@dpesall dpesall mentioned this pull request Nov 6, 2024
Open
@HaLaGu1L HaLaGu1L mentioned this pull request Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AaronMoat @IvanGoncharov