Skip to content

Conversation

stenreijers
Copy link
Contributor

This is the same fix for invalid error propagation on custom scalars, but now backported for 16.x.x

see:
#3837

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Hi @stenreijers, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@stenreijers
Copy link
Contributor Author

I had to do two commits, because I run locally with a newer version of NPM, so the second commit is to restore the original package-lock.json such that github can do its checks.

@stenreijers
Copy link
Contributor Author

stenreijers commented Feb 14, 2023

Any ETA on this backport @IvanGoncharov ?

@IvanGoncharov
Copy link
Member

@stenreijers Sorry for the delay.
Looking at it right now.

@IvanGoncharov IvanGoncharov merged commit 076972e into graphql:16.x.x Feb 15, 2023
@IvanGoncharov IvanGoncharov added the PR: bug fix 🐞 requires increase of "patch" version number label Feb 17, 2023
@stenreijers
Copy link
Contributor Author

@IvanGoncharov when can we expect a bump on the 16.x branch for a new npm package?

@IvanGoncharov
Copy link
Member

@stenreijers I will do release on Friday 📦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants