incrementalDelivery: fix iterable streaming with errors #3729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
robrichard
approved these changes
Sep 7, 2022
When iterables (not asyncIterables) are streamed, and completeValue throws an error, we currently send undefined rather than null, due to a typo. This change corrects the typo, and also modifies the test intended to check this case to correctly check a streamed iterable, rather than an asyncIterable. Code coverage was complete prior to this change, because the line involving this change was reached in the case where the error was non-recoverable, albeit with the line throwing.
yaacovCR
force-pushed
the
fix-complete-value-error
branch
from
018aa20 to
f472c02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When iterables (not asyncIterables) are streamed, and completeValue throws an error, we currently send undefined rather than null, due to a typo.
This change corrects the typo, and also modifies the test intended to check this case to correctly check a streamed iterable, rather than an asyncIterable.
Code coverage was complete prior to this change, because the line involving this change was reached in the case where the error was non-recoverable, albeit with the line throwing.