Skip to content

Conversation

IvanGoncharov
Copy link
Member

No description provided.

@IvanGoncharov IvanGoncharov added the PR: dependency 📦 Dependency management (add/delete/update) label Jul 7, 2022
@netlify
Copy link

netlify bot commented Jul 7, 2022

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 5572fe1
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/62c6d6bcf08eae00097d15fb
😎 Deploy Preview https://deploy-preview-3667--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Hi @IvanGoncharov, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@IvanGoncharov IvanGoncharov merged commit de916c8 into graphql:main Jul 7, 2022
@IvanGoncharov IvanGoncharov deleted the pr_branch4 branch July 7, 2022 13:01
@@ -505,6 +505,7 @@ overrides:
'@typescript-eslint/ban-tslint-comment': error
'@typescript-eslint/ban-types': off # TODO temporarily disabled
'@typescript-eslint/class-literal-property-style': off # TODO enable after TS conversion
'@typescript-eslint/consistent-generic-constructors': error
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new rule triggered a couple small code changes ⬇️

@@ -9,7 +9,7 @@ The simplest way to run a GraphQL API server is to use [Express](https://express
npm install express express-graphql graphql --save
```

Let's modify our “hello world” example so that it's an API server rather than a script that runs a single query. We can use the 'express' module to run a webserver, and instead of executing a query directly with the `graphql` function, we can use the `express-graphql` library to mount a GraphQL API server on the “/graphql” HTTP endpoint:
Let's modify our “hello world” example so that it's an API server rather than a script that runs a single query. We can use the 'express' module to run a web server, and instead of executing a query directly with the `graphql` function, we can use the `express-graphql` library to mount a GraphQL API server on the “/graphql” HTTP endpoint:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cspell begin to error on it and I think web server is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: dependency 📦 Dependency management (add/delete/update)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant