Create codeql-analysis.yml #3162
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjmahone
reviewed
Jul 23, 2021
| # the `language` matrix defined below to confirm you have the correct set of | ||
| # supported CodeQL languages. | ||
| # | ||
| name: "CodeQL" |
There was a problem hiding this comment.
I'm not sure this belongs in graphql-js? There's no description on your diff, @IvanGoncharov, and I'm not always hip on the latest open source tooling, so I'm not totally sure how CodeQL's yml file getting added to the graphql-js repo benefits us.
https://securitylab.github.com/tools/codeql/ => it seems like anyone who wants to use CodeQL can, without defaulting everyone who downloads graphql-js to run it. I may be missing some of the benefits or purpose of CodeQL here, though, or what it's actually doing. Is this essentially just setting up a "code analysis" test, similar to our test coverage tests?
There was a problem hiding this comment.
@mjmahone Sorry, I opened this PR through GitHub UI (content is autogenerated), so it wasn't my intention to merge it just to give it a spin.
About why we need it, it is used by various tools to score the security of a particular OSS project, e.g. https://github.com/ossf/scorecard/blob/main/docs/checks.md#sast
Also, it can uncover some real security issues both in our sorce code and GitHub
workflows.
without defaulting everyone who downloads graphql-js to run it.
No, you don't need to install it or run it.
It just runs on CI, so it doesn't affect local workflow.
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Aug 16, 2022
Motivation: increase security. Discovered while looking into graphql#3162
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Aug 16, 2022
Motivation: increase security. Discovered while looking into graphql#3162
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Aug 16, 2022
Motivation: codeql are quite popular now, moreover various projects use it as metric on how secure certain OSS project is. Example: https://github.com/ ossf/scorecard/blob/main/docs/checks.md#sast Also, it can uncover some real security issues both in our sorce code and GitHub workflows. So I don't see a lot of harm by enabling it, we can always ignore certain files or disable it completely. Fixes graphql#3162
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Aug 16, 2022
Motivation: codeql are quite popular now, moreover various projects use it as metric on how secure certain OSS project is. Example: https://github.com/ ossf/scorecard/blob/main/docs/checks.md#sast Also, it can uncover some real security issues both in our sorce code and GitHub workflows. So I don't see a lot of harm by enabling it, we can always ignore certain files or disable it completely. Fixes graphql#3162
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Aug 16, 2022
Motivation: codeql are quite popular now, moreover various projects use it as metric on how secure certain OSS project is. Example: https://github.com/ ossf/scorecard/blob/main/docs/checks.md#sast Also, it can uncover some real security issues both in our sorce code and GitHub workflows. So I don't see a lot of harm by enabling it, we can always ignore certain files or disable it completely. Fixes graphql#3162
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Aug 16, 2022
Motivation: codeql are quite popular now, moreover various projects use it as metric on how secure certain OSS project is. Example: https://github.com/ ossf/scorecard/blob/main/docs/checks.md#sast Also, it can uncover some real security issues both in our sorce code and GitHub workflows. So I don't see a lot of harm by enabling it, we can always ignore certain files or disable it completely. Fixes graphql#3162
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Aug 16, 2022
Motivation: codeql are quite popular now, moreover various projects use it as metric on how secure certain OSS project is. Example: https://github.com/ ossf/scorecard/blob/main/docs/checks.md#sast Also, it can uncover some real security issues both in our sorce code and GitHub workflows. So I don't see a lot of harm by enabling it, we can always ignore certain files or disable it completely. Fixes graphql#3162
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Aug 17, 2022
Motivation: codeql are quite popular now, moreover various projects use it as metric on how secure certain OSS project is. Example: https://github.com/ ossf/scorecard/blob/main/docs/checks.md#sast Also, it can uncover some real security issues both in our sorce code and GitHub workflows. So I don't see a lot of harm by enabling it, we can always ignore certain files or disable it completely. Fixes graphql#3162
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Aug 18, 2022
Motivation: codeql are quite popular now, moreover various projects use it as metric on how secure certain OSS project is. Example: https://github.com/ ossf/scorecard/blob/main/docs/checks.md#sast Also, it can uncover some real security issues both in our sorce code and GitHub workflows. So I don't see a lot of harm by enabling it, we can always ignore certain files or disable it completely. Fixes graphql#3162
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Aug 29, 2022
Motivation: codeql are quite popular now, moreover various projects use it as metric on how secure certain OSS project is. Example: https://github.com/ ossf/scorecard/blob/main/docs/checks.md#sast Also, it can uncover some real security issues both in our sorce code and GitHub workflows. So I don't see a lot of harm by enabling it, we can always ignore certain files or disable it completely. Fixes graphql#3162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.