Refine parse and AST to represent ConstValue #3059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leebyron
force-pushed
the
const-value-ast
branch
2 times, most recently
from
a7be8ab to
0e53b31
Compare
This adds: * ConstValueNode - A subtype of ValueNode which recursively excludes Variables * Improved syntax error when encountering variable in a const value * parseConstValue(): ConstValueNode * isConstValue(): ConstValueNode * Various refinements to AST types to use ConstValueNode (or a type which includes it) to better align to the spec.
IvanGoncharov
added
the
PR: feature 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds: