Provides a correct OperationType without name in GraphQLPrinter #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,6 +34,23 @@ describe('Printer', () => { | |||
| ); | |||
| }); | |||
|
|
|||
| it('correctly prints non-query operations without name', () => { | |||
There was a problem hiding this comment.
This test could potentially be within kitchen sink test, but I felt like I'd slow down the tests using it. Let me know if you think otherwise.
|
Sweet, thanks so much for digging into this! |
asiandrummer
force-pushed
the
printer
branch
2 times, most recently
from
5540f64 to
bf9e385
Compare
| @@ -31,7 +31,8 @@ const printDocASTReducer = { | |||
| const defs = wrap('(', join(node.variableDefinitions, ', '), ')'); | |||
| const directives = join(node.directives, ' '); | |||
| const selectionSet = node.selectionSet; | |||
| return !name ? selectionSet : | |||
| return !name ? !directives && !defs && (!op || op === `query`) ? | |||
There was a problem hiding this comment.
@leebyron thanks for the good catch - especially that query with directives/variable defs would ignore the artifacts and only show the selectionSet, treating it as a short-handed query. Added explicit checks for that exact condition, as well as tests for it.
leebyron
added a commit
that referenced
this pull request
Feb 9, 2016
Provides a correct OperationType without name in GraphQLPrinter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #288. Simply inserts another check to see OperationType is
queryand only omit the keyword in that case. Formutation(andsubscription) the query string should still contain OperationType.