Add Python 3 support #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dustymugs, did you want me to look at this? |
|
I always welcome peer review ;-) I'm testing this code now between py2 and py3 |
|
Last time I looked into adding python3 (~1 year ago) it need some GDAL patches to be merged. It looks like those are in, so the min version of GDAL needs to bumped up. Only tricky thing is that I'm not sure what the version of GDAL is in brew/ubuntu ppa, so it could make installation a bit of a pain. To get around this I just created a docker with everything installed. |
|
Agreed for GDAL. Minimum should just bump up to 2.2, especially given convenience of conda... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be Python 2 compatible.