Only automatically build images for pushed tags #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
approved these changes
Aug 27, 2025
|
That sounds good to me. What we could try if we had that too is having two Dockerfiles, one for the boringcrypto build and one for the normal build, but the normal build could cross-compile then. |
|
I'll merge this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image builds in CI are taking 50m+ each on every commit to
main. This happens even for changes that don't touch the code like github action updates. It would be nice to make the image builds faster, but for now I think restricting the image builds to tag pushes makes sense. If someone needs an image between releases they can still build one manually.