build: remove source maps, src from package #2812
Conversation
Signed-off-by: gpbl <[email protected]>
| }, | ||
| "files": [ | ||
| "dist", | ||
| "src", |
There was a problem hiding this comment.
The styles files in the exports configuration are still referencing the src path, I think this will cause #2714 again.
There was a problem hiding this comment.
Good point, thanks! I added back the styles only.
There was a problem hiding this comment.
@gpbl FYI, the same code changes we have in this PR were the cause of the issue.
This issue will likely happen again.
There was a problem hiding this comment.
Yeah I bet the issue there was related to source maps, which I'd like to remove here - after all the code is not minified and I don't see benefits of having them. Do you agree?
There was a problem hiding this comment.
For sure, I think it's better to provide the source code with the package, and bundler can compute the source map from it.
Signed-off-by: gpbl <[email protected]>
|
Thanks for the review @rodgobbi ! |
2 participants
Addresses #2763