Feature: Add support for <Characters> field from ComicInfo.xml #2105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements full support for the <Characters> field from ComicInfo.xml specification: Backend changes: - Added BOOK_METADATA_CHARACTER and BOOK_METADATA_AGGREGATION_CHARACTER database tables - Created Flyway migration V20251012120000__book_metadata_characters.sql - Extended BookMetadata, BookMetadataPatch, and SeriesMetadataAggregation models - Updated ComicInfoProvider to parse <Characters> field - Added characters to MetadataApplier and MetadataAggregator - Implemented SearchCondition.Character for filtering - Added /api/v1/characters REST endpoint Frontend changes: - Added characters field to TypeScript types (komga-books.ts, komga-series.ts, komga-search.ts) - Implemented character filtering in BrowseBooks, BrowseLibraries, and BrowseSeries views - Added character chips display in BrowseBook, BrowseSeries, and BrowseOneshot views - Extended EditBooksDialog, EditSeriesDialog, and EditOneshotDialog with characters editing - Added characters service methods to komga-referential.service.ts - Added English translations for characters UI labels Testing: - Updated TransientBookLifecycleTest and ComicInfoProviderTest This feature allows users to: - Import characters from ComicInfo.xml files - View characters on book/series detail pages - Filter books and series by characters - Edit characters metadata manually - Search for characters across libraries
|
thanks, but that's not something i am interested in adding to Komga for the moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Backend (Kotlin/Spring Boot)
/api/v1/charactersFrontend (Vue.js/TypeScript)
Testing
Checklist
Related discussion #1551
Additional Notes