Skip to content

Fix Dependency.cs IsGreater() detection of + characters on version2 string #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2021
Merged

Fix Dependency.cs IsGreater() detection of + characters on version2 string #443

merged 1 commit into from
Jun 22, 2021

Conversation

@DellaBitta
Copy link
Collaborator

@DellaBitta DellaBitta commented Jun 22, 2021 •
edited by chkuang-g
Loading

Fix #442.

Dependnecy.cs was using version1 string to detect a '+' suffix for the version2 string in the IsGreater method.

@DellaBitta DellaBitta requested a review from chkuang-g June 22, 2021 13:36
@chkuang-g chkuang-g merged commit 2c4ed46 into master Jun 22, 2021
@chkuang-g chkuang-g deleted the bugfix/version2-trim branch June 22, 2021 18:04
@chkuang-g chkuang-g mentioned this pull request Jun 22, 2021
Closed
@googlesamples googlesamples locked and limited conversation to collaborators Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chkuang-g chkuang-g chkuang-g approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Confusing version comparison: version2 = version1.EndsWith("+")

2 participants

@DellaBitta @chkuang-g