Skip to content

Conversation

lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Aug 29, 2025

Dependencies CI Test: https://github.com/googleapis/sdk-platform-java/actions/runs/17332601428

Local invocation of renovate shows that it is able to match the versions:

{
                 "depName": "com.fasterxml.jackson:jackson-bom",
                 "currentValue": "2.19.2",
                 "datasource": "maven",
                 "replaceString": "com.fasterxml.jackson:jackson-bom=2.19.2\n",
                 "updates": [
                   {
                     "bucket": "non-major",
                     "newVersion": "2.20.0",
                     "newValue": "2.20.0",
                     "releaseTimestamp": "2025-08-28T22:48:03.000Z",
                     "newVersionAgeInDays": 0,
                     "newMajor": 2,
                     "newMinor": 20,
                     "newPatch": 0,
                     "updateType": "minor",
                     "isBreaking": false,
                     "branchName": "renovate/com.fasterxml.jackson-jackson-bom-2.x"
                   }
                 ],
                 ...
             ],
             "matchStrings": ["(?<depName>.*)=(?<currentValue>.*)\\n"],
             "datasourceTemplate": "maven",
             "packageFile": "dependencies.txt"
           }

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Aug 29, 2025
<commons-codec.version>1.18.0</commons-codec.version>
<httpcore.version>4.4.16</httpcore.version>
<httpclient.version>4.5.14</httpclient.version>
<httpcore5.version>5.2.5</httpcore5.version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there is the possibility that the artifactId may be duplicated across OSS projects. Could be enhanced so that it is {groupId}.{artifactId}.version format

<grpc.version>1.71.0</grpc.version>
<google.auth.version>1.37.1</google.auth.version>
<google.http-client.version>1.47.1</google.http-client.version>
<grpc-bom.version>1.71.0</grpc-bom.version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a possibility that there are other pom.xml files that inherit from here and shared-deps that use these values. Would we consider changing these property names a breaking change?

Copy link

Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant