-
Notifications
You must be signed in to change notification settings - Fork 68
chore: Add renovate custom manager to update upper-bound files #3894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
<commons-codec.version>1.18.0</commons-codec.version> | ||
<httpcore.version>4.4.16</httpcore.version> | ||
<httpclient.version>4.5.14</httpclient.version> | ||
<httpcore5.version>5.2.5</httpcore5.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess there is the possibility that the artifactId may be duplicated across OSS projects. Could be enhanced so that it is {groupId}.{artifactId}.version
format
<grpc.version>1.71.0</grpc.version> | ||
<google.auth.version>1.37.1</google.auth.version> | ||
<google.http-client.version>1.47.1</google.http-client.version> | ||
<grpc-bom.version>1.71.0</grpc-bom.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a possibility that there are other pom.xml
files that inherit from here and shared-deps that use these values. Would we consider changing these property names a breaking change?
|
|
Dependencies CI Test: https://github.com/googleapis/sdk-platform-java/actions/runs/17332601428
Local invocation of renovate shows that it is able to match the versions: