Skip to content

refactor: microgen - rename variables, edit docstrings #2319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 14, 2025
Merged

refactor: microgen - rename variables, edit docstrings #2319

merged 11 commits into from
Oct 14, 2025

Conversation

@chalmerlowe
Copy link
Collaborator

@chalmerlowe chalmerlowe commented Oct 9, 2025 •
edited
Loading

This PR:

  • refactors the names of several variables for additional clarity
  • edits logic to capture None and typehints that were being missed (e.g. Dict in certain cases)
  • updates noxfile.py so that tests will run
  • adds tests for the parse_code() and parse_file() methods
  • fixes a minor lint error

@chalmerlowe chalmerlowe requested review from a team as code owners October 9, 2025 16:52
@chalmerlowe chalmerlowe requested review from Linchin and removed request for a team October 9, 2025 16:52
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 9, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Oct 9, 2025
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Oct 9, 2025
@chalmerlowe chalmerlowe changed the title refactor: rename variables, edit docstrings refactor: microgen - rename variables, edit docstrings Oct 9, 2025
@chalmerlowe chalmerlowe added this to the µgen PoC milestone Oct 9, 2025
@chalmerlowe chalmerlowe merged commit 1466881 into autogen Oct 14, 2025
21 checks passed
@chalmerlowe chalmerlowe deleted the refactor/rename-variables-edit-docstrings branch October 14, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

@Linchin Linchin Awaiting requested review from Linchin Linchin is a code owner automatically assigned from googleapis/api-bigquery

Assignees

@leahecole leahecole

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: l Pull request size is large.

Projects

None yet

Milestone

µgen PoC

Development

Successfully merging this pull request may close these issues.

4 participants

@chalmerlowe @daniel-sanche @leahecole