-
Notifications
You must be signed in to change notification settings - Fork 110
fix(deps): update dependency grpc-gcp to ^0.3.0 #885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency grpc-gcp to ^0.3.0 #885
Conversation
d0fa2f8
to
fb3843f
Compare
fb3843f
to
f015859
Compare
f015859
to
367dd5c
Compare
367dd5c
to
08a4c7b
Compare
08a4c7b
to
3834883
Compare
3834883
to
b80c199
Compare
b80c199
to
33b786f
Compare
33b786f
to
93d902c
Compare
93d902c
to
4b29fae
Compare
4b29fae
to
5464a66
Compare
eaa7bae
to
8bc30cb
Compare
'grpc-gcp' module can't be found according to the test failures.
@murgatroid99 if I could get you to take a look at the way we're doing the import, that would be really helpful. I tried to follow your comments in GoogleCloudPlatform/grpc-gcp-node#67 but I wasn't able to figure out how to get the imports working. Line 42 in f0c6be5
|
Codecov Report
@@ Coverage Diff @@
## master #885 +/- ##
==========================================
+ Coverage 97.74% 98.10% +0.36%
==========================================
Files 20 20
Lines 18266 17964 -302
Branches 965 989 +24
==========================================
- Hits 17854 17624 -230
+ Misses 410 339 -71
+ Partials 2 1 -1
Continue to review full report at Codecov.
|
8bc30cb
to
e75377d
Compare
The new version of import getGrpcGcpObjects = require('grpc-gcp');
const grpcGcp = getGrpcGcpObjects(grpc); @alexander-fenster has told me that |
Yes, gax exports the gRPC implementation. I will take care of this. |
e75377d
to
cd5df74
Compare
cd5df74
to
c470f6f
Compare
c470f6f
to
16971ee
Compare
Hmmm, I attempted to fix the import in 16971ee but it didn't work :( I'm afraid I don't know how to fix this. |
PR has been edited👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description. |
This one is in my plans for the next week. We need to update |
Thanks @alexander-fenster for taking this on. AFAICT, this is not a breaking change so would it be ok if I do the 5.0.0 release without this? |
Autoclosing SkippedThis PR has been flagged for autoclosing, however it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error. |
This PR contains the following updates:
^0.1.1
->^0.3.0
Release Notes
GoogleCloudPlatform/grpc-gcp-node
v0.3.0
Compare Source
Renovate configuration
📅 Schedule: "after 9am and before 3pm" (UTC).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.