Skip to content

Conversation

renovate-bot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
grpc-gcp dependencies minor ^0.1.1 -> ^0.3.0

Release Notes

GoogleCloudPlatform/grpc-gcp-node

v0.3.0

Compare Source

  • Rework library to be compatible with grpc-js (#​67)

Renovate configuration

📅 Schedule: "after 9am and before 3pm" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 4, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 4, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 4, 2020
@renovate-bot renovate-bot force-pushed the renovate/grpc-gcp-0.x branch from d0fa2f8 to fb3843f Compare April 5, 2020 20:13
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 5, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 5, 2020
@renovate-bot renovate-bot force-pushed the renovate/grpc-gcp-0.x branch from fb3843f to f015859 Compare April 10, 2020 01:19
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 10, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 10, 2020
@renovate-bot renovate-bot force-pushed the renovate/grpc-gcp-0.x branch from f015859 to 367dd5c Compare April 10, 2020 18:58
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 10, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 10, 2020
@renovate-bot renovate-bot force-pushed the renovate/grpc-gcp-0.x branch from 367dd5c to 08a4c7b Compare April 11, 2020 01:49
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 11, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 11, 2020
@renovate-bot renovate-bot force-pushed the renovate/grpc-gcp-0.x branch from 08a4c7b to 3834883 Compare April 12, 2020 03:14
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 12, 2020
@renovate-bot renovate-bot force-pushed the renovate/grpc-gcp-0.x branch from 3834883 to b80c199 Compare April 12, 2020 06:13
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 12, 2020
@renovate-bot renovate-bot force-pushed the renovate/grpc-gcp-0.x branch from b80c199 to 33b786f Compare April 13, 2020 22:13
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 13, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 13, 2020
@renovate-bot renovate-bot force-pushed the renovate/grpc-gcp-0.x branch from 33b786f to 93d902c Compare April 14, 2020 03:13
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 14, 2020
@renovate-bot renovate-bot force-pushed the renovate/grpc-gcp-0.x branch from 93d902c to 4b29fae Compare April 14, 2020 04:14
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 14, 2020
@renovate-bot renovate-bot force-pushed the renovate/grpc-gcp-0.x branch from 4b29fae to 5464a66 Compare April 14, 2020 16:56
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 14, 2020
@renovate-bot renovate-bot force-pushed the renovate/grpc-gcp-0.x branch from eaa7bae to 8bc30cb Compare April 15, 2020 05:02
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 15, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 15, 2020
@skuruppu
Copy link
Contributor

'grpc-gcp' module can't be found according to the test failures.

src/index.ts:42:8 - error TS2307: Cannot find module 'grpc-gcp'.

42 } from 'grpc-gcp';
          ~~~~~~~~~~

@murgatroid99 if I could get you to take a look at the way we're doing the import, that would be really helpful. I tried to follow your comments in GoogleCloudPlatform/grpc-gcp-node#67 but I wasn't able to figure out how to get the imports working.

} from 'grpc-gcp';

@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #885 into master will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #885      +/-   ##
==========================================
+ Coverage   97.74%   98.10%   +0.36%     
==========================================
  Files          20       20              
  Lines       18266    17964     -302     
  Branches      965      989      +24     
==========================================
- Hits        17854    17624     -230     
+ Misses        410      339      -71     
+ Partials        2        1       -1     
Impacted Files Coverage Δ
src/index.ts 100.00% <0.00%> (ø)
src/database.ts 99.90% <0.00%> (+0.04%) ⬆️
src/common-grpc/service.ts 100.00% <0.00%> (+0.09%) ⬆️
src/transaction-runner.ts 99.15% <0.00%> (+0.28%) ⬆️
src/codec.ts 100.00% <0.00%> (+0.32%) ⬆️
src/common-grpc/service-object.ts 100.00% <0.00%> (+0.65%) ⬆️
src/v1/spanner_client.ts 99.20% <0.00%> (+0.88%) ⬆️
src/v1/instance_admin_client.ts 99.04% <0.00%> (+0.95%) ⬆️
src/v1/database_admin_client.ts 99.33% <0.00%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3e0cf5...16971ee. Read the comment docs.

@renovate-bot renovate-bot force-pushed the renovate/grpc-gcp-0.x branch from 8bc30cb to e75377d Compare April 15, 2020 14:13
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 15, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 15, 2020
@murgatroid99
Copy link

The new version of grpc-gcp uses export =, so you need to import it with import = require(). What it exports is a function that takes as its argument a grpc implementation and returns the objects exported by the previous version of grpc-gcp. So, using it in typescript would look something like this:

import getGrpcGcpObjects = require('grpc-gcp');
const grpcGcp = getGrpcGcpObjects(grpc);

@alexander-fenster has told me that google-gax exports a reference to the implementation of grpc that it is using, so that should normally be the argument to this function. I expect that like the other client libraries, Spanner will want to accept a grpc implementation reference as a client construction argument. If so, that object should be passed in to both this function and google-gax.

@alexander-fenster
Copy link
Contributor

Yes, gax exports the gRPC implementation. I will take care of this.

@renovate-bot renovate-bot force-pushed the renovate/grpc-gcp-0.x branch from e75377d to cd5df74 Compare April 15, 2020 17:13
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 15, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 15, 2020
@renovate-bot renovate-bot force-pushed the renovate/grpc-gcp-0.x branch from cd5df74 to c470f6f Compare April 18, 2020 04:13
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 18, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 18, 2020
@skuruppu skuruppu force-pushed the renovate/grpc-gcp-0.x branch from c470f6f to 16971ee Compare April 18, 2020 04:21
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 18, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 18, 2020
@skuruppu
Copy link
Contributor

Hmmm, I attempted to fix the import in 16971ee but it didn't work :(

I'm afraid I don't know how to fix this.

@forking-renovate
Copy link

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@alexander-fenster
Copy link
Contributor

This one is in my plans for the next week. We need to update google-gax dependency since it now exports grpc properly. I will take this one.

@alexander-fenster alexander-fenster self-assigned this Apr 19, 2020
@skuruppu
Copy link
Contributor

Thanks @alexander-fenster for taking this on. AFAICT, this is not a breaking change so would it be ok if I do the 5.0.0 release without this?

@forking-renovate
Copy link

Autoclosing Skipped

This PR has been flagged for autoclosing, however it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@renovate-bot renovate-bot deleted the renovate/grpc-gcp-0.x branch May 6, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants