Skip to content

Conversation

Goooler
Copy link

@Goooler Goooler commented Dec 14, 2023

Add ProGuard/R8 keep rules to ensure this lib will be compatible with obfuscation enabled, the files under src/main/resources/META-INF/proguard should be interpreted by R8 automatically.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@Goooler Goooler requested review from a team as code owners December 14, 2023 02:37
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Dec 14, 2023
Add ProGuard/R8 keep rules to ensure this lib will be compatible with obfuscation enabled, the files under `src/main/resources/META-INF/proguard` should be interpreted by R8 automatically.
@Goooler Goooler changed the title Add ProGuard rules for this library chore: add ProGuard rules for this library Dec 14, 2023
@Goooler
Copy link
Author

Goooler commented Dec 14, 2023

Actually, we can just keep a few classes under com.google.api.client.auth instead of all of them, but I have no more time to investigate that.

@meltsufin meltsufin requested a review from a team as a code owner May 23, 2025 14:15
meltsufin
meltsufin previously approved these changes May 23, 2025
@meltsufin meltsufin self-requested a review May 23, 2025 17:32
@meltsufin meltsufin dismissed their stale review May 23, 2025 17:34

testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants