Autoload is hitting disc and checking file_exists on an non existing file

[umpirsky]

Environment details

• OS: FreeBSD
• PHP version: 8.3.6
• Package name and version: v0.396.0

Description

In https://github.com/googleapis/google-api-php-client-services/blob/main/autoload.php#L5 there is a check for src/Google/Client.php file existence.

A fix to remove this is suggested in #4199, but now I think we can even remove entire file and tag a new version.

In #4199 (comment) it is suggested to update the code to use the new namespaces, which we did, and we are still seeing accessing non existing file:

90220 php-fpm  RET   __getcwd 0
90220 php-fpm  CALL  access(0x73a8f48,0<F_OK>)
90220 php-fpm  NAMI  "/www/sites/.../vendor/google/apiclient-services/../apiclient/src/Google/Client.php"
90220 php-fpm  RET   access -1 errno 2 No such file or directory

Which is totally expected since autoload.php contains:

file_exists(__DIR__ . '/../apiclient/src/Google/Client.php')

Steps to reproduce

1. include autoload.php

[bojanpejic]

@bshaffer here is another suggestion:

<?php

// Prefer the modern, namespaced classes if present to avoid unnecessary filesystem checks.
// If the new classes exist (autoloaded via Composer), create aliases for legacy names.
if (class_exists('Google\\Client')) {
    $legacyToModernClassMap = [
        'Google_Client' => 'Google\\Client',
        'Google_Service' => 'Google\\Service',
        'Google_Service_Resource' => 'Google\\Service\\Resource',
        'Google_Model' => 'Google\\Model',
        'Google_Collection' => 'Google\\Collection',
    ];
    foreach ($legacyToModernClassMap as $legacy => $modern) {
        if (!class_exists($legacy, false)) {
            class_alias($modern, $legacy);
        }
    }
} elseif (!class_exists('Google_Client', false)) {
    // Fallback for older (pre-2.7.2) versions of google/apiclient where only legacy classes exist.
    if (file_exists(__DIR__ . '/../apiclient/src/Google/Client.php')) {
        require_once(__DIR__ . '/../apiclient/src/Google/Client.php');
        if (
            defined('Google_Client::LIBVER')
            && version_compare(Google_Client::LIBVER, '2.7.2', '<=')
        ) {
            $servicesClassMap = [
                'Google\\Client' => 'Google_Client',
                'Google\\Service' => 'Google_Service',
                'Google\\Service\\Resource' => 'Google_Service_Resource',
                'Google\\Model' => 'Google_Model',
                'Google\\Collection' => 'Google_Collection',
            ];
            foreach ($servicesClassMap as $alias => $class) {
                class_alias($class, $alias);
            }
        }
    }
}
spl_autoload_register(function ($class) {
    if (0 === strpos($class, 'Google_Service_')) {
        // Autoload the new class, which will also create an alias for the
        // old class by changing underscores to namespaces:
        //     Google_Service_Speech_Resource_Operations
        //      => Google\Service\Speech\Resource\Operations
        $classExists = class_exists($newClass = str_replace('_', '\\', $class));
        if ($classExists) {
            return true;
        }
    }
}, true, true);