chore: add multi-statement support to SpannerLib #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olavloite
force-pushed
the
spanner-lib-multi-statement-support
branch
2 times, most recently
from
9c50e16 to
4b8855a
Compare
olavloite
requested review from
aakashanandg,
bhatt4982,
rahul2393 and
rayudu3745
Collaborator
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for multi-statement SQL strings to SpannerLib, introducing a new NextResultSet function to navigate between result sets. The changes are well-implemented across the Go API, shared library, and gRPC server, with thorough testing. The Java wrappers have also been updated, but I've noted one area for improvement: the gRPC implementation for the Java wrapper is missing the nextResultSet functionality. I've also pointed out a minor issue in the Go API regarding error handling. Overall, this is a solid contribution that adds valuable functionality.
...appers/spannerlib-java/src/main/java/com/google/cloud/spannerlib/GrpcSpannerLibraryImpl.java
Show resolved
Hide resolved
Adds support for multi-statement SQL strings to SpannerLib. This adds a new exported function NextResultSet that moves the pointer to the next result for a multi-statement SQL string. It also updates the return type for the gRPC server, so this returns an indication whether the result contains more result sets. These changes are backwards-compatible with existing implementations for Rows. Wrappers are free to ignore any result sets after the first one.
olavloite
force-pushed
the
spanner-lib-multi-statement-support
branch
from
4b8855a to
6f9ca89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for multi-statement SQL strings to SpannerLib. This adds a new exported function NextResultSet that moves the pointer to the next result for a multi-statement SQL string.
It also updates the return type for the gRPC server, so this returns an indication whether the result contains more result sets.
These changes are backwards-compatible with existing implementations for Rows. Wrappers are free to ignore any result sets after the first one.
Updates #572