fix(cli): only call ResolveFilenames with ProtoImportPaths if specified #1478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slevenick
approved these changes
Feb 20, 2025
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 20, 2025
🤖 I have created a release *beep* *boop* --- ## [1.69.2](https://togithub.com/googleapis/api-linter/compare/v1.69.1...v1.69.2) (2025-02-20) ### Bug Fixes * **AIP-133/AIP-134:** handle qualified lro response type name comparison ([#1475](https://togithub.com/googleapis/api-linter/issues/1475)) ([5e8fe24](https://togithub.com/googleapis/api-linter/commit/5e8fe2442327ab2a3f1833ff77824723d8331e82)) * **cli:** only call ResolveFilenames with ProtoImportPaths if specified ([#1478](https://togithub.com/googleapis/api-linter/issues/1478)) ([6a0ddc6](https://togithub.com/googleapis/api-linter/commit/6a0ddc6d441083d60e7a6e1e35cb0f18f562021e)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only attempt to resolve against the
--proto-pathimport paths if there were some specified, to avoid an error fromprotoparse.ResolveFilenamesthat requires some import path when provided absolute paths. Still want to keep the.resolution separate so that relative input filenames are still able to be resolved against the provided import paths ahead of the attempt to resolve against cwd to avoid proto file name collisions in the subsequent Parse action.Note: Filed separate bug to come up with a testing harness for the CLI #1479
Updates #1465 again improving on that fix and the one for #1471