Skip to content

feat(AIP-203): remove behavior comment checks #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2023
Merged

feat(AIP-203): remove behavior comment checks #1195

merged 1 commit into from
Jul 11, 2023

Conversation

noahdietz
Copy link
Collaborator

Removes the rules that checked field comments for required optional immutable output_only input_only now that every request field must be annotated with field behavior. These rules were a regular source of false positives when the words were simply being used in normal commentary unrelated to field behavior.

Closes #1164 #892 #621

@noahdietz noahdietz requested a review from a team as a code owner July 11, 2023 00:11
@noahdietz noahdietz requested a review from toumorokoshi July 11, 2023 00:11
@noahdietz noahdietz merged commit 5402a46 into googleapis:main Jul 11, 2023
@noahdietz noahdietz deleted the field-behavior branch July 11, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet approved these changes

@toumorokoshi toumorokoshi Awaiting requested review from toumorokoshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIP-203: remove output-only check?
2 participants
@noahdietz @jskeet