Skip to content

fix(AIP-203): remove optional conflict #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 5, 2023
Merged

fix(AIP-203): remove optional conflict #1182

merged 3 commits into from
Jul 5, 2023

Conversation

toumorokoshi
Copy link
Contributor

The AIPs now allow OPTIONAL to be used with other descriptive
annotations (e.g. INPUT_ONLY or IMMUTABLE). Removing the rule
accordingly to minimize confusion.

@toumorokoshi
fix(AIP-203): remove optional conflict
471a656 
The AIPs now allow OPTIONAL to be used with other descriptive
annotations (e.g. INPUT_ONLY or IMMUTABLE). Removing the rule
accordingly to minimize confusion.
@toumorokoshi toumorokoshi requested a review from a team as a code owner June 26, 2023 19:22
jskeet
jskeet approved these changes Jul 3, 2023
View reviewed changes
Copy link

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to remove the rule for now - in time we may want to prohibit specific combinations, e.g. REQUIRED and OPTIONAL, but that can come later.

@toumorokoshi toumorokoshi enabled auto-merge (squash) July 5, 2023 15:37
@toumorokoshi toumorokoshi merged commit 09d127b into googleapis:main Jul 5, 2023
@Juneezee Juneezee mentioned this pull request Jan 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toumorokoshi @jskeet