Skip to content

Conversation

antongolub
Copy link
Collaborator

  • Tests pass
  • Appropriate changes to README are included in PR

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI configuration to use Node.js 24 as the default version instead of Node.js 22. The change affects all GitHub Actions workflows, package.json Volta configuration, and includes test adjustments to accommodate behavior differences in Node.js 24.

  • Updated Node.js version from 22 to 24 across all CI workflows and package configuration
  • Adjusted test expectations to match Node.js 24 behavior, including new fs module exports and timing adjustments
  • Fixed server response handling to properly convert data to UTF-8 strings

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Updated Volta node version from 22.12.0 to 24.6.0
.github/workflows/test.yml Changed Node.js version from 22.x to 24 in test workflow
.github/workflows/publish.yml Updated Node.js version from 22 to 24 in publish workflow
.github/workflows/jsr-publish.yml Updated Node.js version from 22 to 24 in JSR publish workflow
.github/workflows/dev-publish.yml Updated Node.js version from 22 to 24 in dev publish workflow
test/export.test.js Updated fs module exports tests to reflect Node.js 24 API changes
test/core.test.js Added process ID uniqueness test and adjusted timing in unpipe test
test/cli.test.js Updated fake server response to include proper HTTP body
test/fixtures/server.mjs Fixed string handling to properly convert data to UTF-8
test/fixtures/echo.http Updated Content-Length header to match actual response size
scripts/build-versions.mjs Refactored license generation to use a single variable

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@antongolub antongolub merged commit 72b5604 into google:main Aug 21, 2025
29 checks passed
@antongolub antongolub deleted the ci-nodejs24 branch August 21, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant