Skip to content

feat: direct piping to file shortcut #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 17, 2024
Merged

feat: direct piping to file shortcut #1001

merged 3 commits into from
Dec 17, 2024

Conversation

1e9y
Copy link
Contributor

@1e9y 1e9y commented Dec 17, 2024 •
edited
Loading

Now, instead of

await $`echo "Hello, stdout!"`
  .pipe(fs.createWriteStream('/tmp/output.txt'))

you can simply do

await $`echo "Hello, stdout!"`
  .pipe('/tmp/output.txt')

Fixes #976

  • Tests pass
  • Appropriate changes to README are included in PR

antongolub
antongolub approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@antongolub antongolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@antongolub antongolub merged commit 7566081 into google:main Dec 17, 2024
21 checks passed
@antongolub antongolub added the ossln24 OSS Library Night 2024 label Dec 17, 2024
antongolub pushed a commit to antongolub/zx that referenced this pull request Dec 25, 2024
feat: provide stdall piping
984c5db 
continues google#978

fix: add missing fs ref to core
continues google#1001
@antongolub antongolub mentioned this pull request Dec 25, 2024
Merged
2 tasks
antongolub added a commit that referenced this pull request Dec 25, 2024
@antongolub
feat: provide stdall piping (#1033)
775b4b4 
* feat: provide stdall piping
continues #978

fix: add missing fs ref to core
continues #1001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antongolub antongolub antongolub approved these changes

Assignees
No one assigned
Labels
ossln24 OSS Library Night 2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: provide piping to file
2 participants
@1e9y @antongolub